Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 869764196F0 for ; Thu, 29 Apr 2010 02:00:24 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.89 X-Spam-Level: X-Spam-Status: No, score=-1.89 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_MIME_NO_TEXT=0.01] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 53foZeBlAG4m for ; Thu, 29 Apr 2010 02:00:23 -0700 (PDT) Received: from mail-ww0-f53.google.com (mail-ww0-f53.google.com [74.125.82.53]) by olra.theworths.org (Postfix) with ESMTP id 715B2431FC1 for ; Thu, 29 Apr 2010 02:00:23 -0700 (PDT) Received: by wwe15 with SMTP id 15so553682wwe.26 for ; Thu, 29 Apr 2010 02:00:22 -0700 (PDT) Received: by 10.216.157.202 with SMTP id o52mr8731124wek.212.1272531618222; Thu, 29 Apr 2010 02:00:18 -0700 (PDT) Received: from ut.hh.sledj.net (gmp-ea-fw-1b.sun.com [192.18.8.1]) by mx.google.com with ESMTPS id x1sm5583894wbx.7.2010.04.29.02.00.16 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 29 Apr 2010 02:00:17 -0700 (PDT) Received: by ut.hh.sledj.net (Postfix, from userid 1000) id E629159411F; Thu, 29 Apr 2010 10:00:37 +0100 (BST) To: Sebastian Spaeth , Notmuch developer list Subject: Re: [PATCH] emacs: Reuse rather than reinvent message header filtering In-Reply-To: <1272530875-7141-1-git-send-email-Sebastian@SSpaeth.de> References: <1272530875-7141-1-git-send-email-Sebastian@SSpaeth.de> User-Agent: Notmuch/0.3.1-24-gac275ad (http://notmuchmail.org) Emacs/23.1.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Thu, 29 Apr 2010 10:00:34 +0100 Message-ID: <87eihyy6od.fsf@ut.hh.sledj.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2010 09:00:24 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 29 Apr 2010 10:47:55 +0200, Sebastian Spaeth = wrote: > In notmuch-mua-reply we were filtering out the Subject and To headers > manually in a loop, but message mode offers a nice function for > exactly that. Simplify the code by using that. Also, as > notmuch-mua-mail already sorts and hides headers that we want sorted > and hidden, we can safely remove those 2 functions from here as well. >=20 > Signed-off-by: Sebastian Spaeth This looks fine to me (I even tested!). We can also remove "(require 'cl)" now that the use of `loop' is gone. dme. =2D-=20 David Edmondson, http://dme.org --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkvZSrIACgkQaezQq/BJZRa0HwCfS0UmF7s+QK43nEW4XSUTfch9 fLMAn2+uy7JAZ+1Gpp7RS+3DPdGakKQQ =1yBG -----END PGP SIGNATURE----- --=-=-=--