From: Carl Worth <cworth@cworth.org>
To: Sebastian Spaeth <Sebastian@SSpaeth.de>,
	Notmuch developer list <notmuch@notmuchmail.org>
Subject: Re: [PATCH v3 1/4] Add elisp file for FCC to maildir solution
In-Reply-To: <1272270198-28357-1-git-send-email-Sebastian@SSpaeth.de>
References: <m3bpd8tpjk.fsf@x200.gr8dns.org>
	<1272270198-28357-1-git-send-email-Sebastian@SSpaeth.de>
User-Agent: Notmuch/0.2-216-g4b34eff (http://notmuchmail.org) Emacs/23.1.1
	(i486-pc-linux-gnu)
Date: Mon, 26 Apr 2010 14:21:51 -0700
Message-ID: <87sk6hx634.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Mon, 26 Apr 2010 10:23:15 +0200, Sebastian Spaeth <Sebastian@SSpaeth.de>=
 wrote:
>  The patch series needed rebasing as it conflicts now with some of the
>  notmuch-hello and notmuch-mua additions. Also, I integrated Dirk's propo=
sal
>  to use assoc-string which makes the address lookup case-insensitive.

I've merged this now and pushed it out.

I did have some problems trying to use it, which would have prevented me
From=20pushing it out, I think, except that it's disabled by default.

But I would actually prefer to have it enabled by default. Here are
some of the things I'd like to see changed to let us do that:

  * Insert a '/' if necessary when concatenating message-directory to
    the configured directory.

	I was getting "/home/cworth/mailsent" instead of
	"/home/cworth/mail/sent" here.

  * Make the Fcc header visible when composing a message

	Otherwise it's hard to know if the Fcc code is actually getting
	invoked.

	And we do enough magic here, (the above concatenation, and also
	the a-list matching), that we should let the user see the
	result. This would also allow the user to modify the Fcc if
	necessary.

  * Fix code to create directories as necessary

	If I manually added an Fcc header before sending, (even by just
	calling `notmuch-fcc-header-setup'), there is some prompting
	about creating the directory. But I don't get this when I just
	send a message (hoping that the Fcc stuff will kick in and do
	it's job).

	But even if I just point to a directory, (without cur, new, and
	tmp), it complains about "not a regular file" or something. I'd
	rather just have it create the directories it needs.

	I found by trial-and-error that if I do create the directory,
	*and* create the cur, new, and tmp sub-directories then the Fcc
	actually works.

  * Fix to not depend on message-directory variable

	I think a relative directory specification should be interpreted
	with respect to the notmuch mail directory. It's currently a
	little "tricky" for emacs code to get at that since we don't
	have a command-line interface for querying configuration. [Does
	emacs have a parser for this style of configuration file?]

	The quick fix is probably to accept only an absolute path and
	fixup the documentation. Then if someone wants to do the
	additional work to support a directory relative to the notmuch
	mail directory, then that could be done in the future.

With the above in place, I'd be happy to have this all enabled by
default. (But I guess we can't do that until we *do* have support for a
relative path since notmuch won't be able to construct an absolute path
without configuration.)

Then, we can remove the Bcc from the "notmuch reply" output. And we can
add an option for people who would prefer Bcc (or even Cc as keithp
wants) instead of Fcc.

That will all be later than 0.3 though.

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFL1gPv6JDdNq8qSWgRAvb2AJ9mG9fDInXtalmq+D8CEnpBC7kmywCdHQER
7sPHK+4hcP3g1cNtdiHEtj4=
=nVuA
-----END PGP SIGNATURE-----
--=-=-=--