Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D1EC7431FD0 for ; Fri, 5 Aug 2011 14:04:45 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CATYcoZ1X+HN for ; Fri, 5 Aug 2011 14:04:45 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 499C5431FB6 for ; Fri, 5 Aug 2011 14:04:45 -0700 (PDT) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id 27EA666E0270; Fri, 5 Aug 2011 14:00:33 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (gwave-176.ligo.caltech.edu [131.215.114.176]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id 789B566E014A; Fri, 5 Aug 2011 14:00:26 -0700 (PDT) Received: by finestructure.net (Postfix, from userid 1000) id 455692F5; Fri, 5 Aug 2011 14:00:26 -0700 (PDT) From: Jameson Graef Rollins To: Daniel Schoepe , Austin Clements Subject: Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter In-Reply-To: <87sjpfj3a3.fsf@gilead.invalid> References: <1307189970-728-1-git-send-email-daniel.schoepe@googlemail.com> <87mxhxjrry.fsf@gilead.invalid> <20110604215523.GF29861@mit.edu> <87hb85jjgx.fsf@gilead.invalid> <87lixevs2e.fsf@gilead.invalid> <87sjpfj3a3.fsf@gilead.invalid> User-Agent: Notmuch/0.7-41-g8dcabc9 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 05 Aug 2011 14:00:20 -0700 Message-ID: <87liv7r2u3.fsf@servo.factory.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2011 21:04:46 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 05 Aug 2011 17:17:56 +0200, Daniel Schoepe wrote: > On Mon, 06 Jun 2011 18:32:41 +0200, Daniel Schoepe wrote: > I've been using this patch for the past two months now and it has been > working fine. Are there any more suggestions or criticisms about this? Hey, Daniel. This is a really great patch. I've been looking for this functionality for a while. Thanks for implementing it. Following this email I am sending a slightly-tweaked and signed-off version of this patch that includes a couple of minor tweaks (diff below). The first tweak removes an errant white space, and the other modifies the tag-retrieval command to use the "search --output=3Dtags" command instead of the "search-tags" command which was recently deprecated. jamie. diff --git a/emacs/notmuch.el b/emacs/notmuch.el index e9b0ef8..053f0be 100644 =2D-- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -882,12 +882,12 @@ characters as well as `_.+-'. =20 PROMPT is the string to prompt with." (lexical-let =2D ((completions=20 + ((completions (append (list "folder:" "thread:" "id:" "date:" "from:" "to:" "subject:" "attachment:") (mapcar (lambda (tag) (concat "tag:" tag)) =2D (process-lines "notmuch" "search-tags"))))) + (process-lines "notmuch" "search" "--output=3Dtags"= "*"))))) (let ((keymap (copy-keymap minibuffer-local-map)) (minibuffer-completion-table (completion-table-dynamic --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJOPFnkAAoJEO00zqvie6q8UicP/375DYcR8hr4lIQAT50rrQ5M BhJMTRznUR1sHDwnF30hkxknc0BnzDKRm+tt4QO2uEGJ0LSJjO0D4oFLqarlxl0O 9vsQxujhYC2DXlBXGjBwNoa0qGKiq+biB1ximJPer8dEA4S3TdruGIKqzrFHwR4Z jvj/QMBdu52L/+CnnDJF37Pu36RX83FhOC8GMEYPdwS5RB+bNw90Zo6wfNg6Nz9F ELf+BcuSLWkCkZXbR1qlqHDlwzgpOhd+yJX4aFKW2a3Vvtss4Q8rFtSJx7agm+eP +Vg9lCvZu4koVl5Nb3pT+06my1kNRPYkhNQXEm2J7wkZubhrT+iHPWhT0vkgBWIf sqdjRymBgtIWrM5P9wMWqoYEoI1HqjEy3R7MjzCixzRaaKO7/jIQdv+Aax+62JCK +S+7Sl31Y0Zg5JzCrRJ9dIuf+qb6GwvJm9uDsZUx0Et47fjHr8hwLgyAf9J8uoQC 5tTKB21WD6MdmiyknLCpVH+5rGaWtdSpyrrFMIsJtkqtpzXT4FzlNy7nBYkl012S 9oGF02hjh6MmzDp2ISdOB8oeAggKr1VXEm6ZdGJUpXhyNnuVV1MdWPWwuK+LvT/w 6EGoYXvOyzyrvz1ekuxk8EEy64EnfizOytXGiQNfyo+DWPG1fSMJLutKDv908KXj JxUZU8Q8i3paa9DCOTV1 =IHk0 -----END PGP SIGNATURE----- --=-=-=--