Return-Path: <david@tethera.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 4223E431FBD
	for <notmuch@notmuchmail.org>; Mon, 27 Jan 2014 17:56:40 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id kf-OfOsfWP+Y for <notmuch@notmuchmail.org>;
	Mon, 27 Jan 2014 17:56:32 -0800 (PST)
Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 57011431FBC
	for <notmuch@notmuchmail.org>; Mon, 27 Jan 2014 17:56:32 -0800 (PST)
Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
	(envelope-from <david@tethera.net>)
	id 1W7xub-00005m-17; Mon, 27 Jan 2014 21:56:25 -0400
Received: (nullmailer pid 10238 invoked by uid 1000); Tue, 28 Jan 2014
	01:56:21 -0000
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3] build: write VERSION file containing $(VERSION) string
In-Reply-To: <1390859290-10112-1-git-send-email-tomi.ollila@iki.fi>
References: <1390858998-9846-1-git-send-email-tomi.ollila@iki.fi>
	<1390859290-10112-1-git-send-email-tomi.ollila@iki.fi>
User-Agent: Notmuch/0.17+53~g3e1d7f6 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 27 Jan 2014 21:56:21 -0400
Message-ID: <87zjmgkgxm.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
Cc: tomi.ollila@iki.fi
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jan 2014 01:56:40 -0000

Tomi Ollila <tomi.ollila@iki.fi> writes:

> +VERSION:=$(shell gv=`exec git describe --match '[0-9.]*'|sed -e s/_/~/ -e s/-/+/ -e s/-/~/`; test -f VERSION || touch VERSION; read fv < VERSION; test x"$$fv" = x"$$gv" || echo "$$gv" > VERSION; echo "$$gv")

does this need to be one line long? It's a bit scary.

> +# this file may already have been updated.
> +VERSION: version
> +	echo $(VERSION) > version

I'd prefer the build process does not change any version controlled
file. It should be source, or generated, but not both. did  you mean to
write to VERSION here?

d