From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] emacs: less guessing of character set in messages
In-Reply-To: <1353269185-23210-2-git-send-email-tomi.ollila@iki.fi>
References: <id:87txsm23hs.fsf@betacantrips.com>
	<1353269185-23210-1-git-send-email-tomi.ollila@iki.fi>
	<1353269185-23210-2-git-send-email-tomi.ollila@iki.fi>
User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/24.1.1
	(x86_64-pc-linux-gnu)
Date: Sun, 18 Nov 2012 15:25:56 -0500
Message-ID: <87pq3a1wvf.fsf@betacantrips.com>
MIME-Version: 1.0
Content-Type: text/plain
Cc: tomi.ollila@iki.fi
Precedence: list

Tomi Ollila <tomi.ollila@iki.fi> writes:

> The macro with-current-notmuch-show-message executes command
> `notmuch show --format=raw id:...` which just outputs the contents
> of the mail file verbatim (into temporary buffer). In case e.g. utf-8
> locale is used the temporary buffer has buffer-file-coding-system as
> utf-8. In this case Emacs converts the data to multibyte format, guessing
> that input is in utf-8.
> However, the "raw" (MIME) message may contain octet data in any other
> 8bit format, and as no (MIME-)content spesific handling to the message
> is done at this point, conversion to other formats may lose information.
> By setting coding-system-for-read 'no-conversion drops the conversion part
> and makes this handle input as notmuch-get-bodypart-internal() does.
> This marks the broken test in previous change fixed.

This looks good to me, though you might need to apply it with notmuch
show --format="mbox" :).

Ethan