Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6622D431FD6 for ; Tue, 24 Jan 2012 11:25:28 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dL-X9rHrMgHR for ; Tue, 24 Jan 2012 11:25:27 -0800 (PST) Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 8CFB0431FD2 for ; Tue, 24 Jan 2012 11:25:27 -0800 (PST) Received: by werb10 with SMTP id b10so3759100wer.26 for ; Tue, 24 Jan 2012 11:25:26 -0800 (PST) Received: by 10.216.132.19 with SMTP id n19mr1542540wei.31.1327433126115; Tue, 24 Jan 2012 11:25:26 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id n3sm55457495wiz.9.2012.01.24.11.25.24 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Jan 2012 11:25:24 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id DAA7D9FD47; Tue, 24 Jan 2012 19:25:22 +0000 (GMT) To: Jameson Graef Rollins , notmuch@notmuchmail.org Subject: Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. In-Reply-To: <87k44hym3i.fsf@servo.finestructure.net> References: <1327052612-1040-1-git-send-email-dme@dme.org> <1327409620-10133-1-git-send-email-dme@dme.org> <1327409620-10133-2-git-send-email-dme@dme.org> <87k44hym3i.fsf@servo.finestructure.net> User-Agent: Notmuch/0.11+105~g08b3b0f (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Tue, 24 Jan 2012 19:25:19 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Gm-Message-State: ALoCoQkhjAyCaG3679ftzt6ePYyLo3XCB12Ip8M5AbtWguoLkoA8q3Tr7ox/9LVkmVe7eYyEjPTZ X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2012 19:25:28 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 24 Jan 2012 10:46:57 -0800, Jameson Graef Rollins wrote: > On Tue, 24 Jan 2012 12:53:38 +0000, David Edmondson wrote: > > Instead, allow the caller to specify some parameters for the > > button. Rework `notmuch-show-insert-part-multipart/signed' and > > `notmuch-show-insert-part-multipart/encrypted' accordingly. >=20 > Hi, David. I was thinking about this, and it seems to me that returning > the button itself is useful. I can imagine in the future that it might > be useful to be able to modify the button after you've created. Maybe > it's inconvenient to specify all button parameters at creation time. >=20 > Is there a reason it's really necessary to make this change? Can't > callers just ignore the returned button if they don't care about it > further? I can see that maybe it's nice to be able to specify > parameters at creation time, but I'm not sure why that requires throwing > out the returned object as well. Patches 2 and 3 in that series can result in the button not being inserted. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8fBZ8ACgkQaezQq/BJZRas+ACePCcGIo7tkqXJed1U0kvOcx+7 K+wAnAhFhvKbNJlZRX6fxV0WqlyLcVtb =wdye -----END PGP SIGNATURE----- --=-=-=--