DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=sender:from:to:cc:subject:in-reply-to:references:date:message-id
	:mime-version:content-type;
	b=UFYrcvk+DzUflNROjNrX3Dox/bBXcuOBNvcGkyJlyTmAKgRKZHmAFSKAntbGYyzZqu
	peSb/fpEqJMAiF7PWJHhXeNhKN2qTbzFgHZgCFUL2p7PflqAoHMxAqi1kDa4Js+NhwBz
	8AbCLTCizRaK8ig4Jm+UXhSSN+6ozcQ78Jj3A=
Sender: Jed Brown <five9a2@gmail.com>
From: Jed Brown <jed@59A2.org>
To: Carl Worth <cworth@cworth.org>
In-Reply-To: <87k4uspvr7.fsf@yoom.home.cworth.org>
References: <87r5ripfy2.fsf@yoom.home.cworth.org>
	<1259450376-24523-1-git-send-email-jed@59A2.org>
	<1259450376-24523-2-git-send-email-jed@59A2.org>
	<87k4uspvr7.fsf@yoom.home.cworth.org>
Date: Fri, 05 Feb 2010 10:00:31 +0100
Message-ID: <873a1gys40.fsf@59A2.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Subject: Re: [notmuch] [PATCH 2/2] notmuch-reply.c: Handle munged `Reply-To'
	headers.
Precedence: list

On Thu, 04 Feb 2010 12:54:20 -0800, Carl Worth <cworth@cworth.org> wrote:
> And I'm glad I did because that turned up a bug in the patch, (using
> == instead of != for the return value of strcasestr resulted in *all*
> messages with a Reply-To header being considered as munged).

Yikes, I've been using this thing for two months and hadn't noticed.

> Here's one cleanup I made which you might find interesting as a style
> issue (where I prefer naming a function based on what it *does* rather
> than on what it's being *used* for):

Yup, I do the same, but must have been too lazy to think of a decent name.

Jed