Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0BA2B431FB6 for ; Sun, 18 Mar 2012 11:08:25 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OrOENQJCRy-A for ; Sun, 18 Mar 2012 11:08:24 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 5A24B431FAF for ; Sun, 18 Mar 2012 11:08:24 -0700 (PDT) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id EAB17328017; Sun, 18 Mar 2012 11:08:23 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (173-13-121-41-NewEngland.hfc.comcastbusiness.net [173.13.121.41]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id 1EFE2328010; Sun, 18 Mar 2012 11:08:21 -0700 (PDT) Received: by finestructure.net (Postfix, from userid 1000) id 655429C0; Sun, 18 Mar 2012 11:08:11 -0700 (PDT) From: Jameson Graef Rollins To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH] test: add some exclude tests In-Reply-To: <1332091381-16797-1-git-send-email-markwalters1009@gmail.com> References: <20120317155023.GH2670@mit.edu> <1332091381-16797-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.11.1+319~g41042ef (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sun, 18 Mar 2012 11:08:08 -0700 Message-ID: <87pqc9ye7r.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Mar 2012 18:08:25 -0000 --=-=-= On Sun, 18 Mar 2012 17:23:01 +0000, Mark Walters wrote: > Here are some tests for search exclude working in a systematic fashion > as suggested by Austin. Awesome. More tests = good. > In principle I think something like the generate_thread function could > go in to test-lib.sh, but it would need to be written by someone much > familiar with bash quoting than I am. Yeah, that's probably a good idea. It seems generally useful. > At the moment I have left the current exclude tests in the "search" > test: should they be moved here? I would probably put all of the exclude tests (even count/show exclude tests?) into one test script. Might make debugging a bit easier down the line. But there are also plenty of tests that fall under multiple categories, so it's kind of hard to just pick one. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPZiSIAAoJEO00zqvie6q8CQIQAKSCosMD7v1FUF4RCZmLpsy4 1i5XPczJ6XUTTIyYcfc1uadLbPnwCwd1XL2b9pDOwemfbRR7N9ZdwK2yrnz1IYgb t2Y7S2NNKufveU5AAsRY7JCkiitg4xxUztTWPMmJyEKUI6lOK8Vhj2hgq4HVVWcy Bau4MrA5FCkMG9VGiWBvWqwUMkDqL/CPqvZTi+32nNmBuKuOhy3dRxRoPiZX4O6x u2PqpovIDmeZa+j3eEEigV6e59f78WZs7MtsdFXVfD4tBGnV+SiumBDoaHkiQy4o SobY40zBWmTZreEJpBNd0xs7pZaZsAhvCuVViUjx51cKiF6uT1f56FqjaVeA80PO CUqCyhdbxKODkkmQoYedzq50dtNA+TR5dXlTzvKdsTKBC6XsVmPixnfbpoJXDyE1 Dol0C6TcI/2VTVz5t663mcXs+V/oP43atGnhDFgM3mnRDyEJTigocZLPrWacIvWK OqG0P1P8dG8/9AsQtEh5qmxdVZWc+dAfOQmXK5DHqCkY+y+NKW/wwt0vDIde/9mV yF/sogaXaabGoDzOfXoj5I2zxv7G3bYAy3aLsSNqzfiIw/7+8MMgsiJvlfO7sXi4 r51N66nwXb9AwYX2btUvDldFjgNUjEF7wGEYEcB5pOe6UCzizffbP6TVdFaKhLtN wJwMyPJNzWhyDh6fe9t2 =lWDK -----END PGP SIGNATURE----- --=-=-=--