Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A9079431FD0 for ; Sun, 25 Dec 2011 15:36:25 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zeYeuXMykhuu for ; Sun, 25 Dec 2011 15:36:25 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 15819431FB6 for ; Sun, 25 Dec 2011 15:36:24 -0800 (PST) Received: by wibhq2 with SMTP id hq2so5050734wib.26 for ; Sun, 25 Dec 2011 15:36:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=Wur80pmWiZakLJUPXTyK3q0lXMboQMJ5oupFU2WW8ig=; b=cL5wH8Cbmfp/FPWgtcblpfQkPAeSVSTERdUMLE1nvHs9/gtB+kEphOMhqb7MDJSj57 eJ0Q3y86YlhcDGW7uqlmQj/QousaOV7afNKUY95Wy60hhKUHiaRL5oX/ZKaDuzwHP8oQ z56w4uc+PIFckb/GNti39zFXCHEDBulPRrsfs= Received: by 10.180.85.4 with SMTP id d4mr49124650wiz.0.1324856183618; Sun, 25 Dec 2011 15:36:23 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id en20sm52270246wid.10.2011.12.25.15.36.17 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Dec 2011 15:36:18 -0800 (PST) From: Dmitry Kurochkin To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v5 0/4] First step of 'show' rewrite In-Reply-To: <1324752766-29315-1-git-send-email-amdragon@mit.edu> References: <1324698348-27620-1-git-send-email-amdragon@mit.edu> <1324752766-29315-1-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.10.2+116~g4c449d4 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 26 Dec 2011 03:35:32 +0400 Message-ID: <87sjk81ayj.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Dec 2011 23:36:25 -0000 All looks good to me. Let's push it. I have some minor comments, but they are all more of a style preference (e.g. sig_validity vs signature_validity, using conditional operator (x ? y : z) where possible). Regards, Dmitry