Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8C1EA431FAF for ; Mon, 27 Feb 2012 17:52:49 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GPmYH9kJLO9b for ; Mon, 27 Feb 2012 17:52:49 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 03C89431FAE for ; Mon, 27 Feb 2012 17:52:48 -0800 (PST) Received: from fctnnbsc30w-142166230117.dhcp-dynamic.fibreop.nb.bellaliant.net ([142.166.230.117] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1S2CF9-0004bY-Ks; Mon, 27 Feb 2012 21:52:45 -0400 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1S2CF4-0008O2-6T; Mon, 27 Feb 2012 21:52:38 -0400 From: David Bremner To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. In-Reply-To: <1327918561-16245-3-git-send-email-dme@dme.org> References: <1327496913-4946-1-git-send-email-dme@dme.org> <1327918561-16245-1-git-send-email-dme@dme.org> <1327918561-16245-3-git-send-email-dme@dme.org> User-Agent: Notmuch/0.11.1+240~g30b60bb (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 27 Feb 2012 21:52:38 -0400 Message-ID: <8762eriv15.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam_bar: - Cc: =?utf-8?Q?Antoin?= =?utf-8?Q?e_Beaupr=C3=A9?= X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2012 01:52:49 -0000 On Mon, 30 Jan 2012 10:16:01 +0000, David Edmondson wrote: > --- > emacs/notmuch-lib.el | 9 +++++++++ > emacs/notmuch-print.el | 8 ++++++-- > emacs/notmuch-show.el | 5 ++++- > emacs/notmuch.el | 21 +++++++++------------ > 4 files changed, 28 insertions(+), 15 deletions(-) Jameson and Antoine have asked for this patch to be reverted. As far as I understand it the printing code actually crashes on blank subjects if this patch is removed, so it seems to me that that (slightly) outweighs the annoyance caused by printing [No Subject]. I don't find the argument that different people are annoyed I'd be willing to be convinced otherwise, but as it turns out the question is somewhat academic; there have been enough changes that this patch no longer reverts cleanly. So Someone (TM) will have to do some to change the behaviour; it sounds like the sensible thing to do would be to move notmuch-prettify-subject into notmuch-print.el and call it there. d