Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E3178431FAE for ; Sat, 4 Feb 2012 04:38:42 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id II8dp1ex+GGY for ; Sat, 4 Feb 2012 04:38:42 -0800 (PST) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 6FFDD431FAF for ; Sat, 4 Feb 2012 04:38:42 -0800 (PST) Received: from rocinante.cs.unb.ca ([209.226.201.250]) (authenticated bits=0) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id q14CcenQ015292 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Sat, 4 Feb 2012 08:38:41 -0400 Received: from bremner by rocinante.cs.unb.ca with local (Exim 4.77) (envelope-from ) id 1Rtet2-0000Jz-Hp; Sat, 04 Feb 2012 07:38:36 -0500 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH 3/3] lib: Use talloc to simplify cleanup in notmuch_database_open In-Reply-To: <1327816210-29124-3-git-send-email-amdragon@mit.edu> References: <1327816210-29124-1-git-send-email-amdragon@mit.edu> <1327816210-29124-3-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.11.1 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 04 Feb 2012 07:38:36 -0500 Message-ID: <87vcnmsrhv.fsf@rocinante.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Feb 2012 12:38:43 -0000 On Sun, 29 Jan 2012 00:50:10 -0500, Austin Clements wrote: > Previously, we manually "free"d various pointers in > notmuch_database_open. Use a local talloc context instead to simplify > cleanup and eliminate various NULL pointer initializations and > conditionals. pushed all 3. d