From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Thomas Jost <schnouki@schnouki.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 2/4] emacs: Add a face for crypto parts headers
In-Reply-To: <1323797532-597-3-git-send-email-schnouki@schnouki.net>
References: <87d3cx2t38.fsf@rocinante.cs.unb.ca>
	<1323797532-597-1-git-send-email-schnouki@schnouki.net>
	<1323797532-597-3-git-send-email-schnouki@schnouki.net>
User-Agent: Notmuch/0.10.2+96~g74e5ae5 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Fri, 16 Dec 2011 04:56:53 +0400
Message-ID: <8739cltju2.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Tue, 13 Dec 2011 18:32:10 +0100, Thomas Jost <schnouki@schnouki.net> wrote:
> Commit cb841878 introduced new parts handlers for crypto parts, but also
> hardcoded values for their headers face. This replaces these hardcoded values
> with a customizable face.
> ---

Looks good to me.

Regards,
  Dmitry

>  emacs/notmuch-crypto.el |    5 +++++
>  emacs/notmuch-show.el   |    4 ++--
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
> index 44fccae..67c26af 100644
> --- a/emacs/notmuch-crypto.el
> +++ b/emacs/notmuch-crypto.el
> @@ -37,6 +37,11 @@ mode."
>    :group 'notmuch
>    :type 'boolean)
>  
> +(defface notmuch-crypto-part-header
> +  '((t (:foreground "blue")))
> +  "Face used for crypto parts headers."
> +  :group 'notmuch)
> +
>  (defface notmuch-crypto-signature-good
>    '((t (:background "green" :foreground "black")))
>    "Face used for good signatures."
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 33ee3d8..ec9c52c 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -457,7 +457,7 @@ current buffer, if possible."
>  
>  (defun notmuch-show-insert-part-multipart/signed (msg part content-type nth depth declared-type)
>    (let ((button (notmuch-show-insert-part-header nth declared-type content-type nil)))
> -    (button-put button 'face '(:foreground "blue"))
> +    (button-put button 'face 'notmuch-crypto-part-header)
>      ;; add signature status button if sigstatus provided
>      (if (plist-member part :sigstatus)
>  	(let* ((from (notmuch-show-get-header :From msg))
> @@ -479,7 +479,7 @@ current buffer, if possible."
>  
>  (defun notmuch-show-insert-part-multipart/encrypted (msg part content-type nth depth declared-type)
>    (let ((button (notmuch-show-insert-part-header nth declared-type content-type nil)))
> -    (button-put button 'face '(:foreground "blue"))
> +    (button-put button 'face 'notmuch-crypto-part-header)
>      ;; add encryption status button if encstatus specified
>      (if (plist-member part :encstatus)
>  	(let ((encstatus (car (plist-get part :encstatus))))
> -- 
> 1.7.8
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch