Return-Path: <dme@dme.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id F07C2431FBF
	for <notmuch@notmuchmail.org>; Fri,  9 May 2014 07:17:56 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.7
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id agH1HopBrLWE for <notmuch@notmuchmail.org>;
	Fri,  9 May 2014 07:17:52 -0700 (PDT)
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
	[209.85.212.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 0CA2E431FBC
	for <notmuch@notmuchmail.org>; Fri,  9 May 2014 07:17:51 -0700 (PDT)
Received: by mail-wi0-f174.google.com with SMTP id r20so1397074wiv.13
	for <notmuch@notmuchmail.org>; Fri, 09 May 2014 07:17:50 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:to:subject:in-reply-to:references:user-agent
	:from:date:message-id:mime-version:content-type;
	bh=R66LsYaGOdc06aV7QBo+Oev7P64pzoXsaMOFIlUKwUg=;
	b=CMPjZ3/fA/eBQVnDrc3RaVqjxZfxaHv6uORv0uw4aQDbj92J3YJgzwqPoMz55rqO55
	YRRZ/xosF+o2Fj02rzrIOozZmmTvgh4RdSDzTCCL163DBMCzU+fLRXU6pqUhiDTtB4XI
	O0A/VPFQFi1EV8Z9VuKJ/qGnxv7zsE3AloVef8b5hSKxFhU66s5E9ikpkOEbwzhlpbZB
	/OLo76vlQyj0wjkQt+BmJGEPY/2siFbl6UXZCDvDzg4Xilql3DXT5i21B3gin9vwa/N9
	/3v8T4g+oAgaiL4qLgDpEdvHc2QTjzT0Z8A5vjwl0bXJlnwSpA7YLwdgXCy5Nn4D0yJp
	IOgg==
X-Gm-Message-State:
 ALoCoQlljUGcwGDjGB1jJ6C3Ooj7DEef4GDk1GTyuJmw41ftd4LGDWTHcrPdTVlqtP5OxxJNMnfY
X-Received: by 10.180.11.9 with SMTP id m9mr3501290wib.51.1399645069574;
	Fri, 09 May 2014 07:17:49 -0700 (PDT)
Received: from localhost ([2a01:348:1a2:1:a288:b4ff:fe8a:77d8])
	by mx.google.com with ESMTPSA id d6sm5356001wiz.4.2014.05.09.07.17.46
	for <multiple recipients>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Fri, 09 May 2014 07:17:47 -0700 (PDT)
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v1 0/3] emacs: Allow saving of threads and messages
In-Reply-To: <877g5vb1je.fsf@qmul.ac.uk>
References: <1399623743-30478-1-git-send-email-dme@dme.org>
	<877g5vb1je.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Fri, 09 May 2014 15:17:41 +0100
Message-ID: <cund2fnc9yy.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 09 May 2014 14:17:57 -0000

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Fri, May 09 2014, Mark Walters wrote:
> The first two patches are fine, although I think I like constructing a
> query then quoting rather than quoting bits of a query and bolting them
> together (even the both work).

Agreed. I've no idea what I was thinking.

> My concern is that the current approach gives the user no warning if
> they are about to overwrite an existing file, and that this is true
> regardless of any emacs settings.=20
>
> Could we do these saves by loading into a temporary buffer and then
> using the normal emacs save buffer functions? That way we get the
> benefit of emacs's normal query-overwrite, and respect any user
> customizations of that.

Yes, that is a better approach.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iKYEARECAGYFAlNs44VfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl
bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5
RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRb1HACfWSD4YfI0/TCVWNrUNJLkp1Ke
5/4An3W6AKFMkRCq6FHrzPvfxebkDncG
=5k5y
-----END PGP SIGNATURE-----
--=-=-=--