Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 24D1D431FD0 for ; Fri, 23 Dec 2011 23:55:40 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id faBRbskCGPfk for ; Fri, 23 Dec 2011 23:55:39 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 8D70C431FB6 for ; Fri, 23 Dec 2011 23:55:39 -0800 (PST) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id 10C7E328044; Fri, 23 Dec 2011 23:55:37 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (unknown [208.106.33.208]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id 13C802E50DBB; Fri, 23 Dec 2011 23:55:32 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id 0608E145B; Fri, 23 Dec 2011 23:55:31 -0800 (PST) From: Jameson Graef Rollins To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v4 0/4] First step of 'show' rewrite In-Reply-To: <1324698348-27620-1-git-send-email-amdragon@mit.edu> References: <1323460468-4030-1-git-send-email-amdragon@mit.edu> <1324698348-27620-1-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.10.2+127~g6689686 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 23 Dec 2011 23:55:28 -0800 Message-ID: <87zkeijte7.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 07:55:40 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 23 Dec 2011 22:45:44 -0500, Austin Clements wrot= e: > This addresses Dmitry's and Jameson's review comments from > id:"87k46572f7.fsf@gmail.com" > id:"87liqk5dly.fsf@servo.finestructure.net" > id:"87hb187iu6.fsf@gmail.com" > and rebases to current master. >=20 > I'd like a quick eye over this to make sure I didn't screw anything up > in the latest version, but otherwise I think it's ready to go in. Hey, Austin. Thanks so much for the rework. I have one very minor comment, but other than that it all looks really good to me (as usual). All tests pass as expected when applied to master. I'm looking forward to what else you've got in store on top of this! jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJO9YVwAAoJEO00zqvie6q8XlMP/igB9dT1YVw2djMLdtRDqdaC 34mFsKJl8n70XX0cfEt8JeioBEr0m4p+8DxDf2JV4yIK0N6bKxpPEpLRnLxvWT1A 6PlxNeCgI3azW3RdjkLyeOIs64JVLAI55Gov6Fp8vDXNSZJ2FCtn3g4HS9Ow7wO9 bKHLj9RgvtJqLB+aDXEr21HSzhyNL1O6SkP+zRRHcDURFz7NU/x7M3Rxs4sMRWu7 iuIKSHNi4S3fiI6EjdNN3lGKyiwXUKrZ8OydxWQE7KDwQcqMvSs1txnD+WXHRlIB GVxxu/ocseIFTi33ZsUn9dc2DxdARYZIGe6thIXNZQCDYWP8z1pWvYmbkwdjkDs2 I2XojLkz9MFhbKZoQcwSSBkXMiihujzCK5hakDGXXRlJ8n/3k7V5V+cocWizgLvK +WGWhOJXYQwsbnOcHh3IdsJ+Fr2yuFgRM1e+oC4zYWQracWJqaSOcdfLypmUM9Pp 4FEMilBNdeyj8NO0GrSQ7sBpw0vYxNTLCmdlyy38xViJSB8gLQRq42rvZ1CtheMy ju37b5dAPHXFOaJ8Wf999YWNmMnYd1g0D2tSQkURTuj6QbKDOg9/aNpHjsGXi0Io 9LIpKkiL3+0EVV6VZiLwzH6MMEUSbuA2elAo6k1mQ5gWGR5M1YFigFarQwcV1ewT upeT3ME1VcKj7Q2zl1M2 =By49 -----END PGP SIGNATURE----- --=-=-=--