Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D6A63429E20 for ; Sun, 8 May 2011 14:54:26 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.01 X-Spam-Level: X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w1MnyWmWq0T7 for ; Sun, 8 May 2011 14:54:25 -0700 (PDT) Received: from tesla.chaoflow.net (tesla.chaoflow.net [188.40.54.22]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id C9D7D431FB5 for ; Sun, 8 May 2011 14:54:25 -0700 (PDT) Received: from eve.chaoflow.net (ppp-93-104-187-151.dynamic.mnet-online.de [93.104.187.151]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: flo@chaoflow.net) by tesla.chaoflow.net (Postfix) with ESMTPSA id 1F045C8B4; Sun, 8 May 2011 23:54:24 +0200 (CEST) Received: by eve.chaoflow.net (Postfix, from userid 1000) id DC9762AC; Sun, 8 May 2011 21:54:23 +0000 (Local time zone must be set--see zic manual page) From: Florian Friesdorf To: Austin Clements Subject: Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search In-Reply-To: References: <87liyjgvyw.fsf@servo.factory.finestructure.net> <1304889273-24560-1-git-send-email-flo@chaoflow.net> <1304889273-24560-2-git-send-email-flo@chaoflow.net> User-Agent: Notmuch/0.6 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Sun, 08 May 2011 23:54:17 +0200 Message-ID: <877ha06epi.fsf@eve.chaoflow.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Virus-Scanned: clamav-milter 0.96.5 at tesla X-Virus-Status: Clean Cc: notmuch@notmuchmail.org, Andreas Amann X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 May 2011 21:54:27 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Sun, 8 May 2011 17:40:54 -0400, Austin Clements wrote: > Cool. This seems very reasonable. >=20 > Just some style nits: The three places where you have > "sanitize_string(", there should be a space between the function name > and the paren. fixed > Relatedly, "for(;*loop;loop++){" should be spaced out > like "for (; *loop; loop++) {". fixed > (..)=20 > Also, existing code conventionally uses a variable named "local" > for function-level talloc contexts such as your ctx_quote. In notmuch-search.c there is no variable named "local", in the other functions its also named ctx_quote. Should I rename all ctx_quote to "local"? Will send style fixes after we cleared this. =2D-=20 Florian Friesdorf GPG FPR: 7A13 5EEE 1421 9FC2 108D BAAF 38F8 99A3 0C45 F083 Jabber/XMPP: flo@chaoflow.net IRC: chaoflow on freenode,ircnet,blafasel,OFTC --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAEBAgAGBQJNxxEPAAoJEDj4maMMRfCDYg8QAK24upQa8Zv1KE2wqszPBkLo P9TBb4nqP0VUU51ZUH4uDr+yyUge0YDRkXpGOk5w3KfLqZNnncMb1IXceHUisbJB C0kjNX2c4ioeqWroyVlTTM4er8qahEnTfaSPRtrbqNuLlJera1H5I0Ux/cMmXaiW f6S4IXH6cfhyx3DuzTEvcwaiEmqcAxbuxrzEjghkmW7N9OqLFEZ8ENbE2/G4YtbD MVG+30kKd2LE4GMJKttcgcXOvdtW8mLuD8i5TY/PsZoJAdCSIgxM9l2MvgMlzkUw umubgeXq6F56jMZNvlqHUVnvHQ1SppmdSBoAIydlWzcmD8onXNukANfHz1S1cvyV DRbGa7LaCImCMgjeoGJBDwnLKR/P05fd/2v1kiq7Q3mDEkSymZTb59pTp4iyXk7h ikpX/IvbMZKFVKBV6kwKCtbp5ba37y0ChnK5DwN2o35U15Cvg1RHpX8X2Wz4lzlT 9agVTvYCasxbHwF7c3dBTRq+jjPg93+2oRzh0wqz2KsUW+7DCPzX7T3v0dZoBSBY AF+fKVxYtxnzJQ6JJlhVEh5Hp3ImkiMLWDIvw3072bTI24ECXoNIJOKk9K4GVC+I lFvd69qd4ninHpUm+qNQeoRrKLQZBPs78ZhlK4EdnP8Yo7tonz6JbFDiSVczzpST eaI9DKjrnzytaCFmm99V =AA4U -----END PGP SIGNATURE----- --=-=-=--