Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 16883429E32 for ; Fri, 13 Jan 2012 01:51:08 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YpBxSe+FIGYO for ; Fri, 13 Jan 2012 01:51:06 -0800 (PST) Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 1B4AD429E35 for ; Fri, 13 Jan 2012 01:51:05 -0800 (PST) Received: from pps.filterd (mail-gw3 [127.0.0.1]) by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id q0D9nGjq008662; Fri, 13 Jan 2012 11:50:53 +0200 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by mail-gw3.nixu.fi with ESMTP id 114cs11qy9-1 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Fri, 13 Jan 2012 11:50:53 +0200 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id q0D9oqrv016175; Fri, 13 Jan 2012 11:50:52 +0200 From: Tomi Ollila To: David Edmondson , Xavier Maillard , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: whitespace-cleanup for emacs/*.el files In-Reply-To: References: <1326294815-31926-1-git-send-email-tomi.ollila@iki.fi> User-Agent: Notmuch/0.10.2+176~g3f9d738 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110, 1.0.211, 0.0.0000 definitions=2012-01-13_02:2012-01-13, 2012-01-13, 1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1012030000 definitions=main-1201130028 Cc: Tomi Ollila X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2012 09:51:08 -0000 On Fri, 13 Jan 2012 08:22:49 +0000, David Edmondson wrote: > On Thu, 12 Jan 2012 23:07:03 +0100, Xavier Maillard wrote: > > On Wed, 11 Jan 2012 17:13:35 +0200, Tomi Ollila wrote: > > > Executed > > > for f in emacs/*.el > > > do emacs -q --batch --eval \ > > > "(progn (find-file \"$f\") (whitespace-cleanup) (save-buffer))" > > > done > > > > > > which > > > removed trailing whitespace and empty lines at the end of file > > > removed spaces before tab (if any) > > > converted 8 spaces to tabs in the beginning of line > > > > +1 > > > > Maybe we should note something about this as a /coding style/ rule ? > > How about "Running `indent-region' over the file should produce no > changes" as well? So, In addition to 'uncrustify.cfg' we need emacs reformatter along lines: (defun reformat-elisp-buffer () (interactice) (emacs-lisp-mode) (whitespace-cleanup) (indent-region (point-min) (point-max))) And this located in same directory as 'uncrustify.cfg', wherever that ends up. Tomi