Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 181B9431FAF
	for <notmuch@notmuchmail.org>; Sat,  3 Mar 2012 00:18:54 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id L1i+clO0lxml for <notmuch@notmuchmail.org>;
	Sat,  3 Mar 2012 00:18:52 -0800 (PST)
Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
	by olra.theworths.org (Postfix) with ESMTP id 6DF9A431FAE
	for <notmuch@notmuchmail.org>; Sat,  3 Mar 2012 00:18:52 -0800 (PST)
Received: by guru.guru-group.fi (Postfix, from userid 501)
	id B6E7C68055; Sat,  3 Mar 2012 10:18:50 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/5] Rewrite mbox and raw show formats
In-Reply-To: <1330752025-2542-1-git-send-email-amdragon@mit.edu>
References: <1330752025-2542-1-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.11.1+263~g4fa77d0 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sat, 03 Mar 2012 10:18:50 +0200
Message-ID: <m2399qrtat.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Mar 2012 08:18:54 -0000

On Sat,  3 Mar 2012 00:20:20 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> The show (rewrite) must go on.  These are the last two formats in
> notmuch show proper; the only remaining format is the reply format.
> 
> One of the ultimate goals of the show rewrite is to make raw actually
> work (and probably to split it into two different formats).  This
> series does not do that; it just ports the existing raw format.  I
> plan to make the new raw formats once the rewrite is done.

The whole patch series LGTM.

On somewhat related note: should there be NOTMUCH_STATUS_FAILURE (= 1)
in enum _notmuch_status (indicating unspecified failure). This would make
lines like
   return show_message (ctx, format, message, 0, params) != NOTMUCH_STATUS_SUCCESS;
look better (or were/are all of these failures due to memory exhaustion) ?

Tomi