To: David Bremner <david@tethera.net>, Matthew Lear <matt@bubblegen.co.uk>
Cc: notmuch@notmuchmail.org, Mark Walters <markwalters1009@gmail.com>
Subject: Re: (emacs) Parsing problems replying to encrypted html
In-Reply-To: <87lh4wj4kq.fsf@zancas.localnet>
References: <f50e07855e9bbbdd780ef925d8e2d879.squirrel@webmail.plus.net>
 <m2a8miwc6x.fsf@dme.org>
 <c4ff9f2c141441be10b1cb4b1e0300a7.squirrel@webmail.plus.net>
 <56DD48B3.90604@bubblegen.co.uk> <87mvqatr6y.fsf@zancas.localnet>
 <87h9gigfyz.fsf@bubblegen.co.uk> <87pov58b9y.fsf@zancas.localnet>
 <m260wxkvf3.fsf@guru.guru-group.fi> <87wpp76ctq.fsf@zancas.localnet>
 <m2shzvrccn.fsf@dme.org> <87h9fm315q.fsf@bubblegen.co.uk>
 <87oa9timv7.fsf@zancas.localnet>
 <575b60a1d39a1ecc7d06e5c0d625be61.squirrel@webmail.plus.net>
 <87bn5tjw5e.fsf@tesseract.cs.unb.ca>
 <5ed42cd5aafdc045b5d9e1b918d10748.squirrel@webmail.plus.net>
 <87mvpdgp38.fsf@bubblegen.co.uk> <87lh4wj4kq.fsf@zancas.localnet>
From: David Edmondson <dme@dme.org>
Date: Sun, 03 Apr 2016 19:42:04 +0100
Message-ID: <m2d1q6356r.fsf@dme.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Sat, Apr 02 2016, David Bremner <david@tethera.net> wrote:
> Matthew Lear <matt@bubblegen.co.uk> writes:
>
>>>> Hmm. I can't duplicate the problem replying from show mode with the test
>>>> message you provided.  Is the appropriate key in your gpg keyring?
>>>
>>> Yes it is. I get the gpg gui prompt when opening the encrypted email and
>>> can decrypt it prior to show. As I suspected earlier in the thread, I
>>> wondered if this was related to some emacs config settings/options that I
>>> have. I can't immediately think what they would be though, and why they
>>> would trigger this particular issue for html only. Strange...
>>
>> Do you have the following in your .emacs ?
>>
>> (setq notmuch-multipart/alternative-discouraged '("text/plain"))
>>
>> I think that's the work/not-work switch. I'm not sure if it makes sense
>> or not in terms of seeing the behaviour I do.
>
> OK, with that setting I can duplicate the problem replying to encrypted
> HTML mail.
>
> It's also true that notmuch-reply doesn't include the content in the
> html version of the multipart/alternative. Unlike notmuch show, it
> doesn't have the ability to send parts later, so I guess that's a
> problem there.
>
> The following patch seems to fix it for me. What I haven't worked out is
> if it will break other things. Perhaps David E or Mark (in copy) can
> comment on whether this is a sensible change, given that we now give the
> user control of showing the part on the emacs side.

As an alternative, could you try the patch in
id:1459708823-1852-1-git-send-email-dme@dme.org? I think that this is
really a failure on the emacs side rather than in notmuch proper.

> diff --git a/notmuch-reply.c b/notmuch-reply.c
> index 3c6d685..cd88d79 100644
> --- a/notmuch-reply.c
> +++ b/notmuch-reply.c
> @@ -690,7 +690,7 @@ notmuch_reply_format_sprinter(void *ctx,
>  
>      /* Start the original */
>      sp->map_key (sp, "original");
> -    format_part_sprinter (ctx, sp, node, TRUE, TRUE, FALSE);
> +    format_part_sprinter (ctx, sp, node, TRUE, TRUE, TRUE);
>  
>      /* End */
>      sp->end (sp);