From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/3] Allow emacs to toggle display of all parts
	including multipart
In-Reply-To: <1354496317-24564-1-git-send-email-markwalters1009@gmail.com>
References: <1354496317-24564-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Mon, 03 Dec 2012 22:45:22 +0000
Message-ID: <87zk1uvjp9.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


Hi

I now have a version which does this `right': using invisibility as with
citations and signatures etc. It is working but I need to look through
more carefully before posting.

Best wishes

Mark

On Mon, 03 Dec 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> This is rather more polished version of
> id:1351152563-27277-1-git-send-email-markwalters1009@gmail.com.
>
> The first patch modifies the behaviour of show refresh buffer to keep
> state more accurately where possible. It can never be perfect but it
> makes a reasonable attempt. This is independent of patches 2 and 3.
>
> The second patch allows the user to toggle the visibility of any part
> with 't' on the part button. It does this by storing a list of all
> parts that the user has over-ruled.
>
> The final patch binds the toggle to the default action in cases where
> the part has no filename. Is this a reasonable heuristic? And should
> it be customisable? In all cases the defined actions (save, view,
> other, and toggle) always do their action (ie they do not apply any
> heuristics)
>
> Overall I am pleased with the way it works. The one caveat is that it
> does redisplay the whole buffer when toggling the parts: it might be
> nice to use invisibility but that is beyond my lisp. Moreover it could
> be added at a later stage without changing the user experience.
>
>
> Best wishes
>
> Mark
>
>
> Mark Walters (3):
>   emacs: show: make refresh fix point(ish)
>   emacs: allow the user to toggle the visibility of
>     multipart/alternative parts
>   emacs: show make default part button toggle view when sensible
>
>  emacs/notmuch-show.el |   80 ++++++++++++++++++++++++++++++++++++++----------
>  1 files changed, 63 insertions(+), 17 deletions(-)
>
> -- 
> 1.7.9.1