From: Pieter Praet <pieter@praet.org>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH 1/4] search: rename auto_exclude_tags to {search,
	}exclude_tags
In-Reply-To: <20120119194115.GO16740@mit.edu>
References: <1326586654-16840-3-git-send-email-amdragon@mit.edu>
	<1327000744-25463-1-git-send-email-pieter@praet.org>
	<1327000744-25463-2-git-send-email-pieter@praet.org>
	<20120119194115.GO16740@mit.edu>
User-Agent: Notmuch/0.11+99~gab86e73 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
Date: Thu, 19 Jan 2012 22:14:33 +0100
Message-ID: <87bopzo0na.fsf@praet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

On Thu, 19 Jan 2012 14:41:15 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth Pieter Praet on Jan 19 at  8:19 pm:
> > All other config-related functions and args include the section
> > title in their name, so for the sake of consistency, mirror that.
> > 
> > Also, the "auto"matic part is a given, so that was dropped.
> 
> LGTM other than one nit, below.
> 
> > --- a/notmuch-config.c
> > +++ b/notmuch-config.c
> > @@ -89,9 +89,9 @@ static const char search_config_comment[] =
> >      "\n"
> >      " The following option is supported here:\n"
> >      "\n"
> > -    "\tauto_exclude_tags      A ;-separated list of tags that will be\n"
> > -    "\t excluded from search results by default.  Using an excluded tag\n"
> > -    "\t in a query will override that exclusion.\n";
> > +    "\texclude_tags      A list (separated by ';') of the tags that will be\n"
> > +    "\t\texcluded from search results by default.  Using an excluded tag in a\n"
> > +    "\t\tquery will override that exclusion.\n";
> 
> I'd propose that any tag whose name is more than seven characters long
> should have its description start under it, indented by a tab, like I
> did in id:"1326920205-31296-1-git-send-email-amdragon@mit.edu".  That
> looks nice and keeps the description indented consistently without
> ridiculous amounts of negative space and narrow wrapping.

Oh, nice.  Looks like I should first work down to inbox zero
(still got a looong way to go :/...) before submitting patches.

I'll wait for yours to be pushed before resubmitting this series.


Peace

-- 
Pieter