Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 212C842119F for ; Mon, 23 Jan 2012 10:05:58 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gFOQsNE2NuAz for ; Mon, 23 Jan 2012 10:05:57 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 54708421192 for ; Mon, 23 Jan 2012 10:05:53 -0800 (PST) Received: by wgbdt12 with SMTP id dt12so2883140wgb.2 for ; Mon, 23 Jan 2012 10:05:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.180.102.169 with SMTP id fp9mr15207983wib.9.1327341952212; Mon, 23 Jan 2012 10:05:52 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id dr5sm43607679wib.0.2012.01.23.10.05.50 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 Jan 2012 10:05:51 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id EC197A0950; Mon, 23 Jan 2012 18:05:48 +0000 (GMT) From: David Edmondson To: notmuch@notmuchmail.org Subject: [PATCH 1/4 v42] test: Don't return the result of checking for running emacs to the tester. Date: Mon, 23 Jan 2012 18:05:44 +0000 Message-Id: <1327341947-29206-1-git-send-email-dme@dme.org> X-Mailer: git-send-email 1.7.8.3 In-Reply-To: <1326804748-8989-2-git-send-email-dme@dme.org> References: <1326804748-8989-2-git-send-email-dme@dme.org> X-Gm-Message-State: ALoCoQn0HAQtyqIkP1LhcgMgH7SFO9QevHbAC8j/4hycE05TYLf05lluvkUmMEHuarXS18vtZakS X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2012 18:05:58 -0000 When checking for a running emacs, test_emacs evaluates the empty list '()'. This returns 'nil' when emacs is running, which is then prepended to the actual test result. Given that it is not part of the actual test output the test harness can incorrectly report test failure (or success). --- Commentary updated. test/test-lib.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 0da60fb..82c686c 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -926,7 +926,7 @@ test_emacs () { --eval '(orphan-watchdog $$)'" || return EMACS_SERVER="$server_name" # wait until the emacs server is up - until test_emacs '()' 2>/dev/null; do + until test_emacs '()' >/dev/null 2>/dev/null; do sleep 1 done fi -- 1.7.8.3