Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id BBDF6431FC1 for ; Mon, 26 Apr 2010 15:36:26 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -4.2 X-Spam-Level: X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zq5sw-l8fwD2 for ; Mon, 26 Apr 2010 15:36:26 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by olra.theworths.org (Postfix) with ESMTP id F26AA4196F2 for ; Mon, 26 Apr 2010 15:36:24 -0700 (PDT) Received: from localhost ([::1] helo=x200.gr8dns.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1O6Wud-0005XK-OJ; Mon, 26 Apr 2010 22:36:23 +0000 Received: by x200.gr8dns.org (Postfix, from userid 500) id C8E00CC990; Mon, 26 Apr 2010 15:28:02 -0700 (PDT) From: Dirk Hohndel To: Carl Worth , David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: More DWIM when editing messages In-Reply-To: <87d3xmdsxq.fsf@yoom.home.cworth.org> References: <1272290485-14217-1-git-send-email-dme@dme.org> <87d3xmdsxq.fsf@yoom.home.cworth.org> User-Agent: Notmuch/0.2-223-g4675048 (http://notmuchmail.org) Emacs/23.1.1 (i386-redhat-linux-gnu) Date: Mon, 26 Apr 2010 15:28:02 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2010 22:36:26 -0000 On Mon, 26 Apr 2010 10:28:33 -0700, Carl Worth wrote: > On Mon, 26 Apr 2010 09:31:49 -0700, Dirk Hohndel wrote: > > On Mon, 26 Apr 2010 15:01:25 +0100, David Edmondson wrote: > > > For composing new messages and forwarding, leave the cursor on the > > > 'To:' field. For replies, leave the cursor at the start of the > > > body. In all cases, mark the buffer as not modified so that the user > > > is not prompted if she decides to immediately kill the buffer. > > > > YES! Brilliant. I didn't realize how much I wanted it till you sent > > this. Carl, please include in 0.3 > > Agreed! This is *so* pleasant. > > Thanks, David! This is pushed. This appears not to have gone out??? Must be that weird MUA that I'm using... >From cbd9c96450f6481433877410bcf075d482b4be1b Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Mon, 26 Apr 2010 10:41:49 -0700 Subject: [PATCH] Put signatures at the very end of the message The existing code inserts the signature before inserting the message body (which it puts at the very end of the buffer - therefore AFTER the signature). This little snippet makes us search backwards and insert the message body before a signature, if it exists. Signed-off-by: Dirk Hohndel --- emacs/notmuch-mua.el | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index c7a9aee..9fbb94a 100644 --- a/emacs/notmuch-mua.el +++ b/emacs/notmuch-mua.el @@ -98,11 +98,16 @@ list." collect header))) (message-sort-headers) (message-hide-headers) + ;; insert the message body - but put it in front of the signature + ;; if one is present (goto-char (point-max)) + (if (re-search-backward "-- " nil t) + (forward-line -1) + (goto-char (point-max))) (insert body)) - (set-buffer-modified-p nil) + (set-buffer-modified-p nil) - (message-goto-body)) + (message-goto-body)) (defun notmuch-mua-forward-message () (message-forward) -- 1.6.6.1 -- Dirk Hohndel Intel Open Source Technology Center