From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 7/6] emacs: Improved `notmuch-describe-keymap'
	documentation
In-Reply-To: <1381186131-27552-1-git-send-email-amdragon@mit.edu>
References: <1381029768-11883-1-git-send-email-amdragon@mit.edu>
	<1381186131-27552-1-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Tue, 08 Oct 2013 07:46:45 +0100
Message-ID: <87ob70qmy2.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list


Hello

This looks good to me +1

Best wishes

Mark

On Mon, 07 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:
> ---
>  emacs/notmuch.el | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index e559472..c47c6b5 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -141,10 +141,15 @@ This is basically just `format-kbd-macro' but we also convert ESC to M-."
>        (concat desc " "))))
>  
>  (defun notmuch-describe-keymap (keymap ua-keys &optional prefix tail)
> -  "Return a list of strings, each describing one key in KEYMAP.
> +  "Return a list of strings, each describing one binding in KEYMAP.
>  
> -Each string gives a human-readable description of the key and the
> -first line of documentation for the bound function."
> +Each string gives a human-readable description of the key and a
> +one-line description of the bound function.  See `notmuch-help'
> +for an overview of how this documentation is extracted.
> +
> +UA-KEYS should be a key sequence bound to `universal-argument'.
> +It will be used to describe bindings of commands that support a
> +prefix argument.  PREFIX and TAIL are used internally."
>    (map-keymap
>     (lambda (key binding)
>       (cond ((mouse-event-p key) nil)
> -- 
> 1.8.4.rc3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch