From: Jani Nikula <jani@nikula.org>
To: Antoine =?utf-8?Q?Beaupr=C3=A9?= <anarcat@koumbit.org>, David Edmondson
	<dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] add notmuch keybinding 'd'
In-Reply-To: <87k454wq0e.fsf@marcos.anarcat.ath.cx>
References: <1266408746-28549-1-git-send-email-Sebastian@SSpaeth.de>
	<1310841600-28281-1-git-send-email-anarcat@koumbit.org>
	<cunvcos6dhp.fsf@hotblack-desiato.hh.sledj.net>
	<8762gsy2xp.fsf@nikula.org> <87k454wq0e.fsf@marcos.anarcat.ath.cx>
User-Agent: Notmuch/0.10.2+182~g93862a2 (http://notmuchmail.org) Emacs/23.3.1
	(i686-pc-linux-gnu)
Date: Fri, 06 Jan 2012 23:33:32 +0200
Message-ID: <87aa608qj7.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list


Hi Antoine -

On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupr=C3=A9 <anarcat@koumbit.o=
rg> wrote:
> On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula <jani@nikula.org> wrote:
> > I wouldn't use it either, and I don't use "deleted" tag in the first
> > place. And even if I used it, I'd still like to keep the distinction
> > between "deleted after reading" and "deleted unread", which this patch
> > loses by removing the "unread" tag.
>=20
> I have been using this for months now.
>=20
> But honestly, I don't care much anymore: the hard part is not the tag,
> it's what you do with it after (hint: just remove the damn file).
>=20
> Most patches I have submitted here haven't been accepted and I have to
> painfully reroll my own packages every time there's a new release, which
> has been a very frustrating experience. To see such a trivial patch
> obsoleted tops it.

This patch, while trivial, fixes a specific use case for you, according
to your preferences. I was hoping for something more generic, and
Jameson showed how this can be done in one's .emacs without adding new
code (or carrying your own patches) at all. If this approach does not
work for you, please let us know why!

> For the curious, those (other) patches are:
>=20
>  * lib: add 'safe' setting for flags
>  * lib: Add back the synchronization of 'T' flag with deleted tag
>  * run notmuch-hello-mode-hook at the end of the hello mode setup
>=20
> Most of those do not change the current behavior, and I have been
> running them for more than 4 months.

I haven't looked at the patches, but please understand that not changing
the current behaviour is not a sufficient reason for inclusion. Once in,
people will start using the features, which will need to be maintained
and supported potentially for a very long time. Once in, it's not easy
to take features out. Especially so for lib. So we need to be careful.

Tests have also become an increasingly important part in getting any
non-trivial changes in. It's not enough that they work perfectly now; we
need to be able to make sure later changes won't break them.

> I'd very much like to get help to get this in...=20

I'll try to find a moment to review your other patches.

I've also had my moments of frustration, but things have really improved
significantly since you've sent those patches. David is doing an
excellent job. Be persistent!


Kind regards,
Jani.