From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] emacs: Fix notmuch-hello-tag-list-make-query
 defcustom
In-Reply-To: <87obv8so40.fsf@gmail.com>
References:
 <864e58d004c991bcb823e0f61f33eb8cbbbb5b76.1316804530.git.jani@nikula.org>
	<87obv8so40.fsf@gmail.com>
User-Agent: Notmuch/0.10.2+96~g74e5ae5 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Fri, 16 Dec 2011 16:29:14 +0400
Message-ID: <87k45wsns5.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Fri, 16 Dec 2011 16:22:07 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Hi Jani.
> 
> On Fri, 23 Sep 2011 22:03:41 +0300, Jani Nikula <jani@nikula.org> wrote:
> > It was not possible to define custom filters or filter functions because
> > the types were const. Remove const to allow editing.
> > 
> 
> How about making "Unread messages" query configurable as well?
> 

Oh, we have "Custom filter" option for that.

Should the "Custom filter" have a default value of "tag:unread"?  That
would be consistent with custom function options having a default value.

Regards,
  Dmitry

> Regards,
>   Dmitry
> 
> > Signed-off-by: Jani Nikula <jani@nikula.org>
> > ---
> >  emacs/notmuch-hello.el |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> > index 65fde75..ad1a13f 100644
> > --- a/emacs/notmuch-hello.el
> > +++ b/emacs/notmuch-hello.el
> > @@ -66,8 +66,8 @@ Finally this can be a function that will be called for each tag and
> >  should return a filter for that tag, or nil to hide the tag."
> >    :type '(choice (const :tag "All messages" nil)
> >  		 (const :tag "Unread messages" "tag:unread")
> > -		 (const :tag "Custom filter" string)
> > -		 (const :tag "Custom filter function" function))
> > +		 (string :tag "Custom filter")
> > +		 (function :tag "Custom filter function"))
> >    :group 'notmuch)
> >  
> >  (defcustom notmuch-hello-hide-tags nil
> > -- 
> > 1.7.4.1
> > 
> > _______________________________________________
> > notmuch mailing list
> > notmuch@notmuchmail.org
> > http://notmuchmail.org/mailman/listinfo/notmuch