Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1F032431FAF for ; Fri, 16 Mar 2012 07:58:11 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t-04T5i8xE0o for ; Fri, 16 Mar 2012 07:58:10 -0700 (PDT) Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU [18.7.68.37]) by olra.theworths.org (Postfix) with ESMTP id 7DCFB431FAE for ; Fri, 16 Mar 2012 07:58:10 -0700 (PDT) X-AuditID: 12074425-b7f4a6d0000008e0-a8-4f635500910e Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP id E9.54.02272.005536F4; Fri, 16 Mar 2012 10:58:08 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q2GEw67b005494; Fri, 16 Mar 2012 10:58:07 -0400 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2GEw5dd013483 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Fri, 16 Mar 2012 10:58:06 -0400 (EDT) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1S8YbV-0004V1-7k; Fri, 16 Mar 2012 10:58:05 -0400 Date: Fri, 16 Mar 2012 10:58:05 -0400 From: Austin Clements To: Justus Winter <4winter@informatik.uni-hamburg.de> Subject: Re: [PATCH] python: fix signature of two wrapped libnotmuch functions Message-ID: <20120316145805.GF2670@mit.edu> References: <1331902592-4785-1-git-send-email-4winter@informatik.uni-hamburg.de> <1331902592-4785-2-git-send-email-4winter@informatik.uni-hamburg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331902592-4785-2-git-send-email-4winter@informatik.uni-hamburg.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hRV1mUITfY3ODNd0GJ26w8mi+s3ZzI7 MHlMPH+azePZqlvMAUxRXDYpqTmZZalF+nYJXBmrp2xiK1jAVLF45yTWBsZnjF2MnBwSAiYS 39fPYYWwxSQu3FvP1sXIxSEksI9R4tWZRrAiIYENjBKfrplDJE4ySex4MokFwlnCKDFh3UIW kCoWAVWJHz/3go1iE9CQ2LZ/OVi3iICpxIYHD9hBbGYBaYlvv5uZuhg5OIQF/CR2fygCCfMK aEtcer6aGWLmdEaJk2u2s0EkBCVOznzCAtGrJXHj30uwXpA5y/9xgIQ5BQIlXl/4yARiiwqo SEw5uY1tAqPQLCTds5B0z0LoXsDIvIpRNiW3Sjc3MTOnODVZtzg5MS8vtUjXQi83s0QvNaV0 EyMorNldVHcwTjikdIhRgINRiYc3kDfJX4g1say4MvcQoyQHk5Io78HgZH8hvqT8lMqMxOKM +KLSnNTiQ4wSHMxKIrxWQkA53pTEyqrUonyYlDQHi5I4r6bWOz8hgfTEktTs1NSC1CKYrAwH h5IEb10IUKNgUWp6akVaZk4JQpqJgxNkOA/Q8EKQGt7igsTc4sx0iPwpRkUpcd5okIQASCKj NA+uF5Z2XjGKA70izDsFpIoHmLLgul8BDWYCGlz0KglkcEkiQkqqgVG69ST3Ce2DKod8Opc8 yM97bqZnrHFQ1tZKlOOWVaNIm6lHBm/qRMu1Ed1RWl8mp/Xski3+mPPgOn8EW433JfXtnSId U/+f4rxgNsVwWucEQZH9lkEuu/cF2WY98+v8lvd9yZeaB8rx184ebK2rcVGzulghdS7jnUTl igVO+5by/3VJMLXJVmIpzkg01GIuKk4EAORTxNsWAwAA Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2012 14:58:11 -0000 Quoth Justus Winter on Mar 16 at 1:56 pm: > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de> Ah, ctypes. Because *of course* it makes sense to guess the type signatures for an ABI that will crash if you guess wrong. LGTM. I'd say it's safe to include in 0.12.