Return-Path: <bremner@unb.ca>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 2C256431FB6
	for <notmuch@notmuchmail.org>; Sat,  1 Sep 2012 19:34:54 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Ijrebvm0tUft for <notmuch@notmuchmail.org>;
	Sat,  1 Sep 2012 19:34:53 -0700 (PDT)
Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 99CFB431FAF
	for <notmuch@notmuchmail.org>; Sat,  1 Sep 2012 19:34:53 -0700 (PDT)
Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net
	([156.34.89.108] helo=zancas.localnet)
	by tesseract.cs.unb.ca with esmtpsa
	(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)
	(envelope-from <bremner@unb.ca>)
	id 1T801R-0007Wp-MZ; Sat, 01 Sep 2012 23:34:52 -0300
Received: from bremner by zancas.localnet with local (Exim 4.80)
	(envelope-from <bremner@unb.ca>)
	id 1T801M-0003iM-9o; Sat, 01 Sep 2012 23:34:44 -0300
From: David Bremner <david@tethera.net>
To: Sascha Silbe <sascha-ml-reply-to-2012-3@silbe.org>,
	notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH 1/3] lib: fix NULL checks for filenames iterators
In-Reply-To: <1340555366-25891-2-git-send-email-sascha-pgp@silbe.org>
References: <1340555366-25891-1-git-send-email-sascha-pgp@silbe.org>
	<1340555366-25891-2-git-send-email-sascha-pgp@silbe.org>
User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/24.1.1
	(x86_64-pc-linux-gnu)
Date: Sat, 01 Sep 2012 23:34:44 -0300
Message-ID: <871uilcfuj.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam_bar: -
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Sep 2012 02:34:54 -0000

Sascha Silbe <sascha-pgp@silbe.org> writes:

> The API documentation (notmuch.h) states that the parameter may be NULL,
> but the implementation only checked the current element, potentially
> dereferencing a NULL pointer in the process.
>

Pushed this one patch.

d