Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 29D2D431FAF
	for <notmuch@notmuchmail.org>; Tue,  5 Jun 2012 10:40:49 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id i3TBoY1GM1VS for <notmuch@notmuchmail.org>;
	Tue,  5 Jun 2012 10:40:48 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 565E2431FAE
	for <notmuch@notmuchmail.org>; Tue,  5 Jun 2012 10:40:48 -0700 (PDT)
Received: by guru.guru-group.fi (Postfix, from userid 501)
	id 0E2A210014D; Tue,  5 Jun 2012 20:40:58 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] test: add test for emacs notmuch-show-strip-re
	function
In-Reply-To:
 <3a9ce3cd2074e311f86f3e416644b2879516ffbf.1338910938.git.jani@nikula.org>
References:
 <3a9ce3cd2074e311f86f3e416644b2879516ffbf.1338910938.git.jani@nikula.org>
User-Agent: Notmuch/0.13.2+7~g08be9ce (http://notmuchmail.org) Emacs/23.1.1
	(x86_64-redhat-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Tue, 05 Jun 2012 20:40:57 +0300
Message-ID: <m2y5o17j2u.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jun 2012 17:40:49 -0000

On Tue, Jun 05 2012, Jani Nikula <jani@nikula.org> wrote:

> The function is used for stripping "re:" from subjects to generate
> "bare subjects". Include broken test for having "re:" in the middle of
> the subject.

LGTM

Tomi

> ---
>  test/emacs-show |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/test/emacs-show b/test/emacs-show
> index 2498564..1ddb28e 100755
> --- a/test/emacs-show
> +++ b/test/emacs-show
> @@ -24,4 +24,17 @@ test_emacs "(notmuch-show \"id:$message_id\")
>  	    (test-visible-output)"
>  test_expect_equal_file OUTPUT EXPECTED
>  
> +test_begin_subtest "Bare subject #1"
> +output=$(test_emacs '(notmuch-show-strip-re "Re: subject")')
> +test_expect_equal "$output" '"subject"'
> +
> +test_begin_subtest "Bare subject #2"
> +output=$(test_emacs '(notmuch-show-strip-re "re:Re: re:  Re:  re:subject")')
> +test_expect_equal "$output" '"subject"'
> +
> +test_begin_subtest "Bare subject #3"
> +test_subtest_known_broken
> +output=$(test_emacs '(notmuch-show-strip-re "the cure: fix the regexp")')
> +test_expect_equal "$output" '"the cure: fix the regexp"'
> +
>  test_done
> -- 
> 1.7.9.5
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch