From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH 4/6] test: fix emacs tests after tagging operations
 changes
In-Reply-To: <20120129225841.GH17991@mit.edu>
References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1327725684-5887-4-git-send-email-dmitry.kurochkin@gmail.com>
	<20120129225841.GH17991@mit.edu>
User-Agent: Notmuch/0.11+134~g7ddba9d (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 30 Jan 2012 03:09:38 +0400
Message-ID: <87d3a285sd.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list

On Sun, 29 Jan 2012 17:58:41 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth Dmitry Kurochkin on Jan 28 at  8:41 am:
> > After the recent tagging operations changes, functions bound to "+"
> > and "-" in notmuch-search and notmuch-show views always read input
> > from the minibuffer.  Use kbd macros instead of calling them directly.
> 
> Should this be folded into the previous patch so these tests aren't
> temporarily broken?

I think it is a common approach for notmuch.  IIRC I sent patches which
changes both code and tests, and I was asked to move the tests to a
separate patch.  So I will leave it as is for now.  Though if you point
me to a relevant discussion or policy, which says that the tests should
be merged, I would be happy to do it.

Regards,
  Dmitry