From: Mark Walters <markwalters1009@gmail.com>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: update search sort order help to match code
In-Reply-To: <1370282191-4526-1-git-send-email-jani@nikula.org>
References: <1370282191-4526-1-git-send-email-jani@nikula.org>
User-Agent: Notmuch/0.15.2+171~ge2f30a2 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Mon, 10 Jun 2013 20:43:13 +0100
Message-ID: <87obbdrbu6.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


LGTM +1

Mark

On Mon, 03 Jun 2013, Jani Nikula <jani@nikula.org> wrote:
> ---
>  emacs/notmuch-lib.el |    7 ++++++-
>  emacs/notmuch.el     |   13 ++-----------
>  2 files changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index 28f78e0..c43d5a9 100644
> --- a/emacs/notmuch-lib.el
> +++ b/emacs/notmuch-lib.el
> @@ -68,7 +68,12 @@
>    :group 'notmuch)
>  
>  (defcustom notmuch-search-oldest-first t
> -  "Show the oldest mail first when searching."
> +  "Show the oldest mail first when searching.
> +
> +This variable defines the default sort order for displaying
> +search results. Note that any filtered searches created by
> +`notmuch-search-filter' retain the search order of the parent
> +search."
>    :type 'boolean
>    :group 'notmuch-search)
>  
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index 26ba7e7..cc62088 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -1030,17 +1030,8 @@ depending on the value of `notmuch-poll-script'."
>  (defun notmuch-search-toggle-order ()
>    "Toggle the current search order.
>  
> -By default, the \"inbox\" view created by `notmuch' is displayed
> -in chronological order (oldest thread at the beginning of the
> -buffer), while any global searches created by `notmuch-search'
> -are displayed in reverse-chronological order (newest thread at
> -the beginning of the buffer).
> -
> -This command toggles the sort order for the current search.
> -
> -Note that any filtered searches created by
> -`notmuch-search-filter' retain the search order of the parent
> -search."
> +This command toggles the sort order for the current search. The
> +default sort order is defined by `notmuch-search-oldest-first'."
>    (interactive)
>    (set 'notmuch-search-oldest-first (not notmuch-search-oldest-first))
>    (notmuch-search-refresh-view))
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch