Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 51ADB429E21 for ; Tue, 3 Jan 2012 02:58:20 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5Evi0lnRrhCd for ; Tue, 3 Jan 2012 02:58:19 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 868A9431FD0 for ; Tue, 3 Jan 2012 02:58:19 -0800 (PST) Received: by wibhq2 with SMTP id hq2so10675875wib.26 for ; Tue, 03 Jan 2012 02:58:16 -0800 (PST) Received: by 10.180.88.10 with SMTP id bc10mr113335693wib.13.1325588296892; Tue, 03 Jan 2012 02:58:16 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id di5sm126017716wib.3.2012.01.03.02.58.14 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 03 Jan 2012 02:58:15 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id 3168EA05D6; Tue, 3 Jan 2012 10:58:13 +0000 (GMT) To: Aaron Ecay , Daniel Schoepe , James Vasile , notmuch@notmuchmail.org Subject: Re: [notmuch] [PATCH] Calls to notmuch get queued and executed asynchronously. In-Reply-To: References: <87vddnlxos.wl%james@hackervisions.org> <87wrbykr13.fsf@gilead.invalid> User-Agent: Notmuch/0.10.2+151~gbf1dc2b (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Tue, 03 Jan 2012 10:58:09 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2012 10:58:20 -0000 --=-=-= Content-Type: text/plain At a quick look your code seems fine. I wonder if async operation should be optional (and non-default?) given that it has different failure modes? --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8C30EACgkQaezQq/BJZRakpgCfWXKLTb1Skv/hCYhyyPQA4cdV 3U0An36ii+YwhwuJeDE0CX7GNPRVwndw =CA5H -----END PGP SIGNATURE----- --=-=-=--