User-Agent: OpenSMTPD enqueuer (Demoostik)
To: notmuch@notmuchmail.org
Subject: using the fringe to indicate good signatures
From: David Edmondson <dme@dme.org>
Date: Thu, 20 Aug 2015 14:12:26 +0100
Message-ID: <m2mvxmxfwl.fsf@heart-of-gold.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain

After listening to bremner, dkg et al. from Heidelberg, I threw together
a quick patch to see how we might indicate signature validity in the
fringe. The intention is to prompt more discussion - this code is not
ready to ship.

The patch is attached. The result looks something like:
    http://dme.org/data/images/notmuch-signed-fringe.png

Thoughts?


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline; filename=signed-fringe.diff
Content-Transfer-Encoding: quoted-printable

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 4dee34b..3d447af 100644
=2D-- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -646,25 +646,46 @@ will return nil if the CID is unknown or cannot be re=
trieved."
       (indent-rigidly start (point) 1)))
   t)
=20
=2D(defun notmuch-show-insert-part-multipart/signed (msg part content-type =
nth depth button)
=2D  (button-put button 'face 'notmuch-crypto-part-header)
=2D  ;; add signature status button if sigstatus provided
=2D  (if (plist-member part :sigstatus)
=2D      (let* ((from (notmuch-show-get-header :From msg))
=2D	     (sigstatus (car (plist-get part :sigstatus))))
=2D	(notmuch-crypto-insert-sigstatus-button sigstatus from))
=2D    ;; if we're not adding sigstatus, tell the user how they can get it
=2D    (button-put button 'help-echo "Set notmuch-crypto-process-mime to pr=
ocess cryptographic MIME parts."))
+;; None of the existing fringe bitmaps are empty.
+(define-fringe-bitmap 'notmuch-show--fringe-empty '[])
=20
=2D  (let ((inner-parts (plist-get part :content))
=2D	(start (point)))
=2D    ;; Show all of the parts.
=2D    (mapc (lambda (inner-part)
=2D	    (notmuch-show-insert-bodypart msg inner-part depth))
=2D	  inner-parts)
+(defun notmuch-show--sigstatus-to-fringe-string (status)
+  (let ((good-bad-ugly (plist-get status :status)))
+    (cond
+     ((string=3D good-bad-ugly "good")
+      (propertize "dummy" 'display
+		  '(left-fringe notmuch-show--fringe-empty notmuch-crypto-signature-good=
)))
+     ;; XXX dme: insert more here.
+     (t nil))))
=20
=2D    (when notmuch-show-indent-multipart
=2D      (indent-rigidly start (point) 1)))
+(defun notmuch-show-insert-part-multipart/signed (msg part content-type nt=
h depth button)
+  (let ((start-of-signed (point)))
+    (button-put button 'face 'notmuch-crypto-part-header)
+
+    (let ((sigstatus (car (plist-get part :sigstatus)))
+	  (from (notmuch-show-get-header :From msg)))
+      ;; Add signature status button if status is provided.
+      (if sigstatus
+	  (notmuch-crypto-insert-sigstatus-button sigstatus from)
+	;; If we're not adding the status, tell the user how they can
+	;; get it.
+	(button-put button 'help-echo "Set notmuch-crypto-process-mime to process=
 cryptographic MIME parts."))
+
+      (let ((inner-parts (plist-get part :content))
+	    (start (point))
+	    (fringe-string (notmuch-show--sigstatus-to-fringe-string sigstatus)))
+	;; Show all of the parts.
+	(mapc (lambda (inner-part)
+		(notmuch-show-insert-bodypart msg inner-part depth))
+	      inner-parts)
+
+	(when notmuch-show-indent-multipart
+	  (indent-rigidly start (point) 1))
+
+	(when fringe-string
+	  (replace-regexp "^" fringe-string nil start-of-signed (point))))
+      )
+    )
   t)
=20
 (defun notmuch-show-insert-part-multipart/encrypted (msg part content-type=
 nth depth button)

--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iKYEARECAGYFAlXV0jpfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl
bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5
RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRZIXACfSBOHJK7eXN/DAXDzvmZ6Tnb0
UQ4An2zRMSiUKRanCDP6VzmQLk8mouAc
=ooKn
-----END PGP SIGNATURE-----
--==-=-=--