From: Jinwoo Lee <jinwoo68@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, David Bremner <david@tethera.net>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] Add a defcustom for whether to block remote images by
	default.
In-Reply-To: <m2sieut13t.fsf@guru.guru-group.fi>
References: <1422495572-40384-1-git-send-email-jinwoo68@gmail.com>
	<87pp9yjbhw.fsf@maritornes.cs.unb.ca>
	<m2sieut13t.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.4.1
	(x86_64-apple-darwin13.2.0)
Date: Thu, 29 Jan 2015 09:31:10 -0800
Message-ID: <yq65mw51h4td.fsf@jinwoo-macbookair.roam.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Thu, Jan 29, 2015 at 12:58 AM, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Thu, Jan 29 2015, David Bremner <david@tethera.net> wrote:
>
>> Jinwoo Lee <jinwoo68@gmail.com> writes:
>>
>>> +	(shr-blocked-images (if notmuch-show-block-remote-images
>>> +				"."
>>> +			      shr-blocked-images)))
>>>      (shr-insert-document dom)
>>>      t))
>>
>> Ideally such a customization would apply to all html renders. I think
>> Tomi did some experiments with w3m and friends, I _think_ they respect
>> gnus-blocked-images, but maybe Tomi can comment.
>
> I did M-x debug-on-entry RET open-network-stream RET  (or an equivalent of
> t that in elisp, but the code I did is now lost & forgotten ;/
>
> The docstring relevant to the renderers below it at the end of this email.
>
> 'gnus-w3m respect gnus-blocked-images
>
> I could not run 'w3m on that system... nor 'w3
>
> There was no effect with 'w3m-standalone -- in this case I'd think it is up
> to w3m binary to load external stuff or not. I presume the same is the
> case with 'links, 'lynx, 'html2text and nil
>
> So, to add to David's suggestion maybe just set both gnus-blocked-images
> and shr-blocked-images to the value of
> notmuch-show-text/html-blocked-images

All right.  I sent another patch that does this.  Thanks, guys!

>
>
> Tomi
>
>
> mm-text-html-renderer is a variable defined in `mm-decode.el'.
> Its value is shr
>
> Documentation:
> Render of HTML contents.
> It is one of defined renderer types, or a rendering function.
> The defined renderer types are:
> `shr': use the built-in Gnus HTML renderer;
> `gnus-w3m': use Gnus renderer based on w3m;
> `w3m': use emacs-w3m;
> `w3m-standalone': use plain w3m;
> `links': use links;
> `lynx': use lynx;
> `w3': use Emacs/W3;
> `html2text': use html2text;
> nil    : use external viewer (default web browser).
>
>
>> d