From: David Bremner <david@tethera.net>
To: Ali Polatel <polatel@gmail.com>, Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH] lib: make find_message{,by_filename) report errors
In-Reply-To: <cover.1317456435.git.alip@exherbo.org>
References: <20110930064712.GA30012@hayalet>
	<cover.1317456435.git.alip@exherbo.org>
User-Agent: Notmuch/0.9~rc1 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 03 Oct 2011 22:10:58 -0300
Message-ID: <8739f9muhp.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Notmuch Mailing List <notmuch@notmuchmail.org>
Precedence: list

On Sat,  1 Oct 2011 11:12:23 +0300, Ali Polatel <polatel@gmail.com> wrote:
> From: Ali Polatel <alip@exherbo.org>
>=20
> Looks like the patch did not make it correctly the first time.
> Resending using git-send-email=E2=84=A2
>=20
> You may also find the commit in my notmuch repository:
> git://github.com/alip/notmuch.git branch: find_message


Hi Ali;

Thanks for reworking this patch. I looked at branch find_message-v2
in your repo. I have a few comments.

- In the comments for _resolve_message_id_to_thread_id I guess thread_id
  should be thread_id_ret?

- in notmuch_database_find_message_by_file_name, I'm not sure why you
  set status to NOTMUCH_STATUS_OUT_OF_MEMORY in the catch block. Is this
  a typo?

- after the DONE: label of the same routine, how is *message_ret destroyed?
  does it need to wait until the talloc context "notmuch" is freed?

- I don't really get the change of user to caller around notmuch.h:286
  It is not a big deal, but I guess we should try to be consistent.

David

=20