From: Aaron Ecay <aaronecay@gmail.com>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal
	into two generally useful functions
In-Reply-To: <1326823531-14549-1-git-send-email-jrollins@finestructure.net>
References: <871uqy19yo.fsf@servo.finestructure.net>
	<1326823531-14549-1-git-send-email-jrollins@finestructure.net>
User-Agent: Notmuch/0.11+62~ge41b0d3 (http://notmuchmail.org) Emacs/24.0.92.1
	(i386-apple-darwin10.8.0)
Date: Tue, 17 Jan 2012 15:10:40 -0500
Message-ID: <m2d3aiay4f.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Tue, 17 Jan 2012 10:05:26 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> Brake up notmuch-show-archive-thread-internal into two new functions:
> 
> notmuch-show-tag-thread-internal: applies a tag to all messages in
> thread.  If option remove flag is t, tags will be removed instead of
> added.
> 
> notmuch-show-next-thread: moves to the next thread in the search
> result.  If given a prefix, will show the next result, otherwise will
> just move to it in the search view.
> 
> Two new interactive functions, notmuch-show-{add,remove}-tag-thread,
> are also added.  Together, these provide a better suit of thread
> tagging and navigation tools.
> 
> The higher level thread archiving functions are modified to use these
> new functions.
> ---
>  emacs/notmuch-show.el |   33 ++++++++++++++++++++++++++-------
>  1 files changed, 26 insertions(+), 7 deletions(-)
> 
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 03c1f6b..3625afd 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1421,12 +1421,29 @@ argument, hide all of the messages."
>    (interactive)
>    (backward-button 1))
>  
> -(defun notmuch-show-archive-thread-internal (show-next)
> -  ;; Remove the tag from the current set of messages.
> +(defun notmuch-show-tag-thread-internal (tag &optional remove)
> +  ;; Add tag to the current set of messages.  If the remove switch is
> +  ;; given, tags will be removed instead of added.

This should be a docstring instead of a comment.  (This applies equally
to the old version....)

-- 
Aaron Ecay