Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7DD72429E2A for ; Tue, 28 Jun 2011 13:28:12 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LTCOYFyVey-H for ; Tue, 28 Jun 2011 13:28:12 -0700 (PDT) Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) by olra.theworths.org (Postfix) with ESMTP id 05515429E25 for ; Tue, 28 Jun 2011 13:28:12 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id D3F4B29A608; Tue, 28 Jun 2011 13:28:10 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id C67942541A8; Tue, 28 Jun 2011 13:28:10 -0700 (PDT) From: Carl Worth To: Mark Anderson , Austin Clements , Mark Anderson Subject: Re: [PATCH] test:Improve test behaviors when --root is used In-Reply-To: <3wd39iuubbs.fsf@testarossa.amd.com> References: <87vcvrw91f.fsf@gmail.com> <3wd39iuubbs.fsf@testarossa.amd.com> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Tue, 28 Jun 2011 13:28:10 -0700 Message-ID: <87sjqt8zvp.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: "notmuch@notmuchmail.org" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2011 20:28:12 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, 27 Jun 2011 17:03:03 -0600, Mark Anderson = wrote: > On Mon, 27 Jun 2011 15:50:47 -0500, Austin Clements wr= ote: > > This looks great (modulo one bug, below). I've wanted to run the > > tests on tmpfs before, but was too lazy to actually fix the tests. Yes, it does look great. Thanks for the patch, Mark! Did you miss Austin's note about a possible bug? (You quoted it but didn't reply). See below: > > > =C2=A0run_test(){ > > > - =C2=A0 =C2=A0result=3D$(LD_LIBRARY_PATH=3D../../lib ./symbol-test 2= >&1) > > > + =C2=A0 =C2=A0result=3D$(LD_LIBRARY_PATH=3D$TEST_DIRECTORY/../../lib= ./symbol-test 2>&1) > >=20 > > Did you mean $TEST_DIRECTORY/../lib? If you could follow up with an updated patch, (or an argument that the original patch is correct), that would be great. =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk4KOVoACgkQ6JDdNq8qSWitbwCghtV/6SJCPC1oooCM00wQ/Ri+ VcUAnA4x+SlAY40qZ3eENSqwhOKq1TzZ =Ujkm -----END PGP SIGNATURE----- --=-=-=--