From: Darren McGuicken <mailing-notmuch@fernseed.info>
To: Jameson Rollins <jrollins@finestructure.net>,
	Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
Subject: Re: bug report: notmuch-hello 'All tags' view
In-Reply-To: <871v73wgvf.fsf@servo.finestructure.net>
References: <87pquogrq7.fsf@yoom.home.cworth.org>
	<87lj5bv7sn.fsf@bookbinder.fernseed.info>
	<87r5f3mqdn.fsf@bookbinder.fernseed.info>
	<87oca7mo90.fsf@bookbinder.fernseed.info>
	<871v73wgvf.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.4 (http://notmuchmail.org) Emacs/23.1.1
	(i486-pc-linux-gnu)
Date: Wed, 03 Nov 2010 20:45:21 +0000
Message-ID: <87iq0em90e.fsf@bookbinder.fernseed.info>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue, 02 Nov 2010 17:33:08 -0400, Jameson Rollins <jrollins@finestructure=
.net> wrote:
> On Tue, 02 Nov 2010 21:03:55 +0000, Darren McGuicken <mailing-notmuch@fer=
nseed.info> wrote:
> > A call to 'notmuch search-tags' from the command line does indeed
> > return an empty string as the first entry for me[1].
>=20
> fwiw, I don't personally get any empty strings in the output of
> search-tags (with 0.4).  So I don't think it's anything inherent to
> that function.

Thanks for the confirmation Jamie - I had a potter with my data and sure
enough, a search for 'tag:""' returned one hit.  I was able to use the
emacs interface to remove the empty string tag from the matching message
('-' then return with no parameters).

So it's probably fair to say that we'll want to handle at least the
empty string scenario as part of our standard tag addition logic since
it can lead to unexpected side effects in searching.

Do we have any other 'known bad' scenarios in tag addition that we want
to catch before I try my hand at a patch?

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkzRyeIACgkQP1ao/7snsT70ewCfTHKbzGBukYFTP1oYbBb2NcYR
1y8An0HNpsVZ5Gy8rcOtp3nCEsJXy6ml
=ZWsO
-----END PGP SIGNATURE-----
--=-=-=--