Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E19C3431FAF for ; Wed, 7 May 2014 08:23:10 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cu4KVLLwD-iJ for ; Wed, 7 May 2014 08:23:05 -0700 (PDT) Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 3D902431FAE for ; Wed, 7 May 2014 08:23:05 -0700 (PDT) Received: by mail-we0-f173.google.com with SMTP id u57so1176287wes.32 for ; Wed, 07 May 2014 08:23:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:cc:subject:in-reply-to:references:user-agent :from:date:message-id:mime-version:content-type; bh=zxrJVDNnkmvaiNUYG5DxJK5nplLEGjqTRxAivtSfz9w=; b=iLNBNjjKoPnXYcxi8Xci3N7c1g/jIHBn/ex5FD9Z1uq7FjDOUmINgZYCLrkk4ybXNr fJ715yNsLRej5oWluoqidgr+dX/Ab1yZZuoRGEMfBPfA2WFGaJKkZIDwFpuJb4ICHrww pB/vqcFR+XlAJSfJQt+4iUwljpKUlPCFdb8WdVMWAPmuloB7SoJAOiokme5Nt9JmVgSS 8zTJhYeEJvIjtWAqK7g4oxz++Ym2hMPvkxjEGfqVqGOkMqVdxP0/xR2u6YjNZPjYIMTQ t8YdlqWs+aBibVHr+pYxawHpK87kzmJMt2Taln5XDDhsMPWdtSrA475DX83DH4TsD3u4 n2ew== X-Gm-Message-State: ALoCoQl+dLo7tJmR9lbm+aGGjOhONjl3qxakHQat183BUHqMTiD7q30bF4ppUZ3Exqm6KzYqptPN X-Received: by 10.194.175.70 with SMTP id by6mr39007962wjc.3.1399476184075; Wed, 07 May 2014 08:23:04 -0700 (PDT) Received: from localhost (disaster-area.hh.sledj.net. [81.149.164.25]) by mx.google.com with ESMTPSA id y20sm32232269wiv.14.2014.05.07.08.22.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 May 2014 08:22:59 -0700 (PDT) To: Pieter Praet Subject: Re: [PATCH v4 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists In-Reply-To: <1327222469-29487-2-git-send-email-pieter@praet.org> References: <871uqsku4h.fsf@praet.org> <1327222469-29487-2-git-send-email-pieter@praet.org> User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Wed, 07 May 2014 16:22:53 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2014 15:23:11 -0000 --=-=-= Content-Type: text/plain [ Trimmed to/cc list. ] On Sun, Jan 22 2012, Pieter Praet wrote: > * emacs/notmuch-show.el (notmuch-show-found-target-p): new predicate function > that uses notmuch(1) 'count' to see if a query turns up any results. > > * emacs/notmuch-show.el (notmuch-show-if-found): new function that only shows > a message/thread if present in the database and otherwise returns an error. > > * emacs/notmuch-show.el (notmuch-show-buttonize-links): some deduplication, > and use new function `notmuch-show-if-found' instead of `notmuch-show' > to prevent showing a blank screen for Message-Id's which aren't present > in the database. Mark provided some feedback about this (relating to exclusions), but more generally there is a problem that `M-x notmuch-show id:doesntexist' will result in an error ("notmuch-show-message-top: Beginning of buffer"). That seems like a bug that should be fixed. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iKYEARECAGYFAlNqT85fFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5 RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRYmggCfSSdarSprlDYE4NRU0y4cwRwd 2ZsAoIQFtSgIxJPOSA/AhLLysShOlTbs =CQh6 -----END PGP SIGNATURE----- --=-=-=--