From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH v5 0/3] Add filter to emacs show mode
Date: Sat, 13 Jun 2015 09:08:07 +0100
Message-Id: <1434182890-8047-1-git-send-email-markwalters1009@gmail.com>
Precedence: list

The previous version of this patch was over 3 years ago at
id:1335658006-20161-1-git-send-email-markwalters1009@gmail.com

The reason the patch stopped was that it marked messages read (removed
the unread tag) spuriously (see Austin's review
id:20120429005736.GK2704@mit.edu) and this was difficult to
fix. However, now the unread handling has been updated this is no
longer a problem. (More precisely, since the unread handling is done
in the command loop hook the unread tag only gets updated after
notmuch has displayed the final result.)

There are two small questions with this version that I would
appreciate views on. First it binds the filter/limit to l since f is
already bound to forward in show mode. It changes the binding in
search mode to match but that may annoy a lot of people who have got f
for filter into muscle memory. If we prefer to leave the keybinding in
search mode as it is then we can just drop the final patch.

Secondly what should the behaviour be if the user just gives and empty
filter query? This patch just opens all messages in the thread (ie it
treats the query as matching everything). Alternatively, it could just
exit without refreshing the buffer in that case.

Best wishes

Mark


Mark Walters (3):
  emacs: split notmuch-show-apply-state
  emacs: add a filter option to show
  emacs: Bind filter in search to 'l'

 emacs/notmuch-show.el | 30 +++++++++++++++++++++++-------
 emacs/notmuch.el      |  4 ++--
 2 files changed, 25 insertions(+), 9 deletions(-)

-- 
2.1.4