Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7467F431FB6 for ; Sun, 2 Sep 2012 08:51:17 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ufYernDCprE0 for ; Sun, 2 Sep 2012 08:51:17 -0700 (PDT) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 0068E431FAF for ; Sun, 2 Sep 2012 08:51:16 -0700 (PDT) Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.89.108] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1T8CSB-0008FC-EX; Sun, 02 Sep 2012 12:51:15 -0300 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1T8CS5-0008Cf-TE; Sun, 02 Sep 2012 12:51:09 -0300 From: David Bremner To: Mark Walters Subject: Re: [PATCH v2 (Draft)] emacs: split async json parser into utility function In-Reply-To: <87k3xlyoek.fsf@qmul.ac.uk> References: <87k3xo85tv.fsf@qmul.ac.uk> <20120730013506.GF8502@mit.edu> <87obmxyokt.fsf@qmul.ac.uk> <87k3xlyoek.fsf@qmul.ac.uk> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/24.1.1 (x86_64-pc-linux-gnu) Date: Sun, 02 Sep 2012 12:51:09 -0300 Message-ID: <87vcfw779u.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Sep 2012 15:51:17 -0000 Mark Walters writes: > Split out the json parser into a utility function. > --- > > Most of this patch is code movement: but I don't see how to arrange the > patch to show that. > "git gui blame notmuch.el" gives some clues, although it isn't perfect. Maybe you could explain in the commit message what is _not_ code movement? > +(defvar notmuch-json-parser nil > + "Incremental JSON parser.") This docstring needs expanding. I suppose that this is for internal use, but it isn't clear from the docstring.