Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1D525431FD7 for ; Sat, 24 Aug 2013 02:41:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G7VQMqJqdSP9 for ; Sat, 24 Aug 2013 02:41:11 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 060DA431FBF for ; Sat, 24 Aug 2013 02:41:11 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1VDALG-0007uE-JY; Sat, 24 Aug 2013 06:41:10 -0300 Received: (nullmailer pid 2914 invoked by uid 1000); Sat, 24 Aug 2013 09:41:05 -0000 From: David Bremner To: Blake Jones , notmuch@notmuchmail.org Subject: Re: [PATCH v3 08/10] notmuch-config: use strchr(), not index() (Solaris support) In-Reply-To: <1352859005-18631-9-git-send-email-blakej@foo.net> References: <1352859005-18631-1-git-send-email-blakej@foo.net> <1352859005-18631-9-git-send-email-blakej@foo.net> User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 24 Aug 2013 11:41:05 +0200 Message-ID: <87a9k7o28e.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Aug 2013 09:41:16 -0000 Blake Jones writes: > notmuch-config.c has the only use of the function named "index()" in the > notmuch source. Several other places use the equivalent function > "strchr()"; this patch just fixes notmuch-config.c to use strchr() > instead. (Solaris needs to include to get the prototype for > index(), and notmuch-config.c was failing to include that header, so it > wasn't compiling as-is.) Pushed this patch, sorry about the delay d