From: David Bremner <david@tethera.net>
To: richardmurri@gmail.com, notmuch@notmuchmail.org
Subject: Re: Fix for emacs 24
In-Reply-To: <877h6x6oor.fsf@veracitynetworks.com>
References: <877h6x6oor.fsf@veracitynetworks.com>
User-Agent: Notmuch/0.7 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Fri, 26 Aug 2011 09:46:27 -0300
Message-ID: <878vqgz6fw.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Mon, 01 Aug 2011 11:12:36 -0600, richardmurri@gmail.com wrote:
> Emacs added another parameter to the send mail functions.  This caused
> emacs to error out.

>  (defun notmuch-mua-mail (&optional to subject other-headers continue
> -				   switch-function yank-action send-actions)
> +				   switch-function yank-action send-actions
> +				   return-action)

Thanks for sending a patch. I'm sure we need lots of help to get notmuch
working well with emacs24. Some comments about your patch

- It would be nice to have a bit more informative single line summary to
  start the patch.

- I don't really understand from the long commit message what problem
  this fixes. I take it some function outside of notmuch is calling
  notmuch-mua-mail? 

- The convention on the notmuch list is to use "git send-email" if you
  can. This makes it easier to apply patches.  Any discussion not meant
  to be part of the commit message can go after the --- at the end of the
  commit message (and I admit that isn't very obvious).

Thanks again, and welcome to the team ;)

d