From: Carl Worth <cworth@cworth.org>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Avoid regexp overflow when tidying citations.
In-Reply-To: <1289566202-24148-1-git-send-email-dme@dme.org>
References: <1289566202-24148-1-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.2.1
	(i486-pc-linux-gnu)
Date: Tue, 16 Nov 2010 11:57:22 -0800
Message-ID: <87eialdot9.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Fri, 12 Nov 2010 12:50:02 +0000, David Edmondson <dme@dme.org> wrote:
> Declare `notmuch-wash-tidy-citations-max', which is the largest region
> that `notmuch-wash-tidy-citations' will attempt to improve.

Hi David,

Could you add a test case for whatever bug is being fixed here?

I'm a little concerned about giving the user a tuning knob which appears
to have a somewhat arbitrary default, and also without providing much
guidance to the user on how to set that particular knob.

I'd feel better if the code could somehow "know" when it needs to stop
tidying well enough that we would feel fine just not offering the knob
at all.

Thanks,

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFM4uIi6JDdNq8qSWgRAhAsAKCdHuT7YJ91TFtWRbeeP1xoxv4aGACfY1gs
cibmzARtOeunsOXa2j/wXJI=
=pwn+
-----END PGP SIGNATURE-----
--=-=-=--