Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id CE430431FD0 for ; Mon, 24 Jan 2011 13:25:29 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EDofX4H1M3dS for ; Mon, 24 Jan 2011 13:25:28 -0800 (PST) Received: from brinza.cc.columbia.edu (brinza.cc.columbia.edu [128.59.29.8]) by olra.theworths.org (Postfix) with ESMTP id 1E91B431FB6 for ; Mon, 24 Jan 2011 13:25:28 -0800 (PST) Received: from servo.finestructure.net (c-24-19-44-201.hsd1.wa.comcast.net [24.19.44.201]) (user=jgr2110 author=jrollins@finestructure.net mech=PLAIN bits=0) by brinza.cc.columbia.edu (8.14.4/8.14.3) with ESMTP id p0OLPMLm012150 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Mon, 24 Jan 2011 16:25:24 -0500 (EST) Received: from jrollins by servo.finestructure.net with local (Exim 4.72) (envelope-from ) id 1PhTuc-0003tk-OJ; Mon, 24 Jan 2011 13:25:22 -0800 From: Jameson Rollins To: Michal Sojka , notmuch@notmuchmail.org Subject: Re: [PATCH 1/4] Import date/time parser from GNU coreutils In-Reply-To: <1295783247-21900-2-git-send-email-sojkam1@fel.cvut.cz> References: <1295783247-21900-1-git-send-email-sojkam1@fel.cvut.cz> <1295783247-21900-2-git-send-email-sojkam1@fel.cvut.cz> User-Agent: Notmuch/0.5-68-g1f03a0f (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Mon, 24 Jan 2011 13:25:18 -0800 Message-ID: <87ei82uh8h.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-No-Spam-Score: Local X-Scanned-By: MIMEDefang 2.68 on 128.59.29.8 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2011 21:25:30 -0000 --=-=-= On Sun, 23 Jan 2011 12:47:24 +0100, Michal Sojka wrote: > This function have quite a lot dependencies. We may reduce them later it > it is a problem. > --- > lib/c-ctype.c | 398 +++++++ > lib/c-ctype.h | 297 +++++ > lib/getdate.c | 3497 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > lib/getdate.h | 22 + > lib/getdate.y | 1572 +++++++++++++++++++++++++ > lib/gettime.c | 48 + > lib/intprops.h | 83 ++ > lib/timespec.h | 39 + > lib/verify.h | 140 +++ > 9 files changed, 6096 insertions(+), 0 deletions(-) > create mode 100644 lib/c-ctype.c > create mode 100644 lib/c-ctype.h > create mode 100644 lib/getdate.c > create mode 100644 lib/getdate.h > create mode 100644 lib/getdate.y > create mode 100644 lib/gettime.c > create mode 100644 lib/gettime.h > create mode 100644 lib/intprops.h > create mode 100644 lib/timespec.h > create mode 100644 lib/verify.h Hi, Michal. I don't fully understand what's going on here, but it seems like you're embedding code copies from somewhere else. If that's the case, is there a reason that we would need to do that, rather than just linking against an external library? jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBCAAGBQJNPe4/AAoJEO00zqvie6q8UDsP+wU9AAXfF76zC1PN+K6qrsOq d9Qg91ewIUaBhMAwOZyzAwyljuJTcjpqNV0nqiUqj45bnVihN8klIAqL+aWbo+Xr JcyFhy9oNTzmniZRKf+JQpWjSWErV7Id/8OFSvRNixj3EzpH7wo9VgINizBaDhhf ELKCwh9zcce4vkmQo423VkEuM7F6gk5qKy9HGVuoe8FPknDK8zh09ITUc7b1SSW4 nDfeGtvqOzq5IfSluaMoKpFOnf1gjTBCRH1yxRXIIq/RFCZX2ZPgeBgAXkcAztSp hGDYYlnJJEyJ2FtwAcEMQ12QGh5B1UA3Jb5DVs4Y8Op8ELULwo5JZl2vrJhNsn32 UlyL/kn7tT6pcvQkZibfbRogdYX+oZAsuk9vZshJtvf17/xSTK5jM2PsSqJsrIsO flBI/LmIZoEAl4gNxg/uKQszB2hAQN6r7p+GvPwFN0IY2yEfkXh+V264Wfy/SfsY MpYv/25GmYzeXUyihfQjpkQ72fj0PODJ/h8c8FkVCssc9Yb0aEMbp2OaVqMGLe6o Fn1z05xGKWJM6CYLDavGrduQc9piAgZbwN9vSRCSEu2ezhh8+paTUkgQOzgBPANA btwty7RT/WF5gfnGEukAz86qfshzUMrqAIalUSrjb6LaPmAJEYaeYX82W2P6yaqJ XcU6r7HAvMLCiRc2yfxp =esJi -----END PGP SIGNATURE----- --=-=-=--