Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 61EB4431FB6 for ; Thu, 3 Feb 2011 09:27:24 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r43N77SjQZ2J for ; Thu, 3 Feb 2011 09:27:23 -0800 (PST) X-Greylist: delayed 62993 seconds by postgrey-1.32 at olra; Thu, 03 Feb 2011 09:27:23 PST Received: from smtprelay03.ispgateway.de (smtprelay03.ispgateway.de [80.67.29.28]) by olra.theworths.org (Postfix) with ESMTP id 6DEC4431FB5 for ; Thu, 3 Feb 2011 09:27:23 -0800 (PST) Received: from [87.180.59.74] (helo=stokes.schwinge.homeip.net) by smtprelay03.ispgateway.de with esmtpa (Exim 4.68) (envelope-from ) id 1Pl2xm-0007Y0-1X for notmuch@notmuchmail.org; Thu, 03 Feb 2011 18:27:22 +0100 Received: (qmail 18335 invoked from network); 3 Feb 2011 17:27:14 -0000 Received: from kepler.schwinge.homeip.net (192.168.111.7) by stokes.schwinge.homeip.net with QMQP; 3 Feb 2011 17:27:14 -0000 Received: (nullmailer pid 21683 invoked by uid 1000); Thu, 03 Feb 2011 17:27:14 -0000 From: Thomas Schwinge To: Austin Clements Subject: Re: [PATCH 2/2] notmuch.el:notmuch-search-process-filter: Rewritten. Cope with incomplete lines. In-Reply-To: References: <87zkqeiffj.fsf@kepler.schwinge.homeip.net> <1296690999-16542-3-git-send-email-thomas@schwinge.name> User-Agent: Notmuch/0.5-33-g665f77b (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Thu, 03 Feb 2011 18:27:07 +0100 Message-ID: <87bp2tghas.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Df-Sender: thomas@schwinge.name Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Feb 2011 17:27:24 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hallo! On Thu, 3 Feb 2011 12:06:20 -0500, Austin Clements wrote: > Is there a reason you keep the remaining data in a string instead of > taking the more idiomatic elisp approach of leaving it in the process > buffer? In fact, the code would probably be simpler if you > immediately appended the string to the process buffer like a normal > process-filter and then peeled things away using buffer-oriented > regexp functions like looking-at. Elisp is a lot better at > manipulating buffers than it is at manipulating strings. Ha, I hear you -- this is what I meant to do originally. But then, the save-in-string approach (even though I always considered keeping state in the string a bit ugly) seemed more simple to me. As I said: writing elisp code is not my primary profession... :-) (Perhaps I should buy a book about it, or something.) Now that you confirmed my original idea, I'll see about re-writing the code accordingly, so thanks for the input! Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEcBAEBAgAGBQJNSuVrAAoJEGe3hdm9kOii4o0IAMnoGunDewAZQy3cVQQX3GCV boAZVKR0Cs0xC+iBmTJ1/UsPiNU4b17Sh2/fu21mSCXQU5Qvh4An8beUd09EsiMu 4Bd9my0/GNIZYeWqR4WA6r4LB8+20Yx7NOq57QkKTFg3OjIxXVR09YnRmTB2DImL /UVQ6aLekG4SqxIJsfJu8qj7OQga2yoBa6J/DaHBfJqqGTbUI/jrEGDGWTvdgySI uzpQ8hyDXtIl+HsDTDmSEkf0p2yY8RT8Xsgn99wroucszWl/BfilcT1tbKnv+gG2 vKCuNJhyCQm4DOaRTJ8gapSu0q7VRbUCxCSd0ITVvcwUrfmfIIRJbQdqXrInMiM= =+E8O -----END PGP SIGNATURE----- --=-=-=--