From: Mark Walters <markwalters1009@gmail.com>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/3] emacs: add notmuch hello refresh hook to display
	message count change
In-Reply-To:
 <627aea74b0080dcd903b801042a4b2fd3868c049.1339775602.git.jani@nikula.org>
References:
 <37899e28dbf67e4620a53279a869be3174c02d6f.1339775602.git.jani@nikula.org>
	<627aea74b0080dcd903b801042a4b2fd3868c049.1339775602.git.jani@nikula.org>
User-Agent: Notmuch/0.13.2+61~gf708609 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Sun, 08 Jul 2012 07:57:20 +0100
Message-ID: <87zk7aviy7.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Fri, 15 Jun 2012, Jani Nikula <jani@nikula.org> wrote:
> Add a notmuch hello refresh hook to display a message about change in
> message count in the database since the notmuch-hello buffer was last
> refreshed manually (no-display is nil).
>
> Signed-off-by: Jani Nikula <jani@nikula.org>

Hi

I just have a couple of comments/queries. First, since it breaks
existing hooks I think it needs a NEWS item. 

Secondly, I, personally, would much prefer the hook with the slight
tweak that it counts inbox messages rather than all messages. Is that
an option that could be put in the defcustom?

Best wishes

Mark

> ---
>  emacs/notmuch-hello.el |   27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index bc43178..bcca044 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -148,6 +148,7 @@ International Bureau of Weights and Measures."
>  (defcustom notmuch-hello-refresh-hook nil
>    "Functions called after updating a `notmuch-hello' buffer."
>    :type 'hook
> +  :options '(notmuch-hello-refresh-status-message)
>    :group 'notmuch-hello
>    :group 'notmuch-hooks)
>  
> @@ -749,6 +750,32 @@ following:
>      (let ((fill-column (- (window-width) notmuch-hello-indent)))
>        (center-region start (point)))))
>  
> +(defvar notmuch-hello-refresh-count 0
> +  "Number of messages in the database when `notmuch-hello' was last run.
> +
> +Used internally by `notmuch-hello-refresh-status-message'.")
> +
> +(defun notmuch-hello-refresh-status-message (no-display)
> +  "Hook to display a status message when refreshing notmuch-hello buffer.
> +
> +Display a status message about the difference in message count in
> +the database since the last call."
> +  (unless no-display
> +    (let* ((new-count
> +	    (string-to-number (car (process-lines notmuch-command "count"))))
> +	   (diff-count (- new-count notmuch-hello-refresh-count)))
> +      (cond
> +       ((= notmuch-hello-refresh-count 0)
> +	(message "You have %s messages."
> +		 (notmuch-hello-nice-number new-count)))
> +       ((> diff-count 0)
> +	(message "You have %s more messages since last refresh."
> +		 (notmuch-hello-nice-number diff-count)))
> +       ((< diff-count 0)
> +	(message "You have %s fewer messages since last refresh."
> +		 (notmuch-hello-nice-number (- diff-count)))))
> +      (setq notmuch-hello-refresh-count new-count))))
> +
>  ;;;###autoload
>  (defun notmuch-hello (&optional no-display)
>    "Run notmuch and display saved searches, known tags, etc."
> -- 
> 1.7.9.5
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch