From: Jani Nikula <jani@nikula.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [Patch v4 8/9] lib: migrate thread.cc to new query_search API
In-Reply-To: <1443367923-11867-9-git-send-email-david@tethera.net>
References: <1443367923-11867-1-git-send-email-david@tethera.net>
 <1443367923-11867-9-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.20.2+101~g7b7dadb (http://notmuchmail.org) Emacs/24.4.1
 (x86_64-pc-linux-gnu)
Date: Mon, 05 Oct 2015 21:27:28 +0300
Message-ID: <878u7h892n.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Sun, 27 Sep 2015, David Bremner <david@tethera.net> wrote:
> here we rely on thread_id_query being attached to the local talloc
> context, so no new cleanup code is needed.

LGTM

> ---
>  lib/thread.cc | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/lib/thread.cc b/lib/thread.cc
> index c8e58c3..0c937d7 100644
> --- a/lib/thread.cc
> +++ b/lib/thread.cc
> @@ -447,6 +447,7 @@ _notmuch_thread_create (void *ctx,
>  
>      notmuch_messages_t *messages;
>      notmuch_message_t *message;
> +    notmuch_status_t status;
>  
>      seed_message = _notmuch_message_create (local, notmuch, seed_doc_id, NULL);
>      if (! seed_message)
> @@ -504,9 +505,11 @@ _notmuch_thread_create (void *ctx,
>       * oldest or newest subject is desired. */
>      notmuch_query_set_sort (thread_id_query, NOTMUCH_SORT_OLDEST_FIRST);
>  
> -    /* XXX: this should use the _st version, but it needs an error path
> -     */
> -    for (messages = notmuch_query_search_messages (thread_id_query);
> +    status = notmuch_query_search_messages_st (thread_id_query, &messages);
> +    if (status)
> +	goto DONE;
> +
> +    for (;
>  	 notmuch_messages_valid (messages);
>  	 notmuch_messages_move_to_next (messages))
>      {
> -- 
> 2.5.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch