MIME-Version: 1.0
Sender: awg@xvx.ca
In-Reply-To: <cunty3to5zp.fsf@hotblack-desiato.hh.sledj.net>
References: <cuny5t6r97c.fsf@hotblack-desiato.hh.sledj.net>
	<1326840818-6821-1-git-send-email-awg+notmuch@xvx.ca>
	<cunty3to5zp.fsf@hotblack-desiato.hh.sledj.net>
Date: Wed, 18 Jan 2012 09:29:08 -0700
Message-ID:
 <CAMoJFUtzGVTpAf6L3TovcXvtc=E8g+EoJj9iu7QHgga5=o3N7A@mail.gmail.com>
Subject: Re: [PATCH v2 4/5] emacs: Use the new JSON reply format.
From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
To: David Edmondson <dme@dme.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: notmuch <notmuch@notmuchmail.org>
Precedence: list

On Tue, Jan 17, 2012 at 23:54, David Edmondson <dme@dme.org> wrote:
> On Tue, 17 Jan 2012 15:53:37 -0700, Adam Wolfe Gordon <awg+notmuch@xvx.ca=
> wrote:
>> +(defun notmuch-parts-filter-by-type (parts type)
>> + =A0"Return a list of message parts with the given type"
>> + =A0(let (result)
>> + =A0 =A0(dolist (part (append parts nil) result)
>> + =A0 =A0 =A0(if (string=3D (cdr (assq 'content-type part)) type)
>> + =A0 =A0 =A0 (setq result (append result (list (cdr (assq 'content part=
)))))))
>> + =A0 =A0result))
>
> I still think that `loop' is easier to read :-) But no objection to this
> code.

I couldn't find the loop construct initially, but after the discussion
of common lisp on IRC yesterday I found the cl package and figured out
how your example worked.  With loop and collect figured out, it is
easier to read.

>> +(defun notmuch-mua-insert-part-quoted (part)
>> + =A0(let ((start (point))
>> + =A0 =A0 limit)
>> + =A0 =A0(insert part)
>> + =A0 =A0(setq limit (point))
>> + =A0 =A0(goto-char start)
>> + =A0 =A0(while (re-search-forward "\\(^\\)[^$]" limit 0)
>> + =A0 =A0 =A0(replace-match "> " nil nil nil 1)
>> + =A0 =A0 =A0;; We have added two characters to the quotable region
>> + =A0 =A0 =A0(setq limit (+ limit 2)))
>> + =A0 =A0(set-buffer-modified-p nil)))
>
> You could use a marker for the limit, as it would then move along
> automagically (sorry for not noticing this last time).

Aha!  Another trick I didn't know about.

New patch forthcoming.