Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 9FBED431FB6 for ; Thu, 20 Dec 2012 07:40:16 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l2r++ll-zbFq for ; Thu, 20 Dec 2012 07:40:13 -0800 (PST) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 0ECEC431FAE for ; Thu, 20 Dec 2012 07:40:13 -0800 (PST) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 268AE100094; Thu, 20 Dec 2012 17:40:06 +0200 (EET) From: Tomi Ollila To: david@tethera.net, notmuch@notmuchmail.org Subject: Re: [PATCH 1/3] CLI: add talloc leak report, controlled by an environment variable. In-Reply-To: <1355714648-23144-2-git-send-email-david@tethera.net> References: <1355714648-23144-1-git-send-email-david@tethera.net> <1355714648-23144-2-git-send-email-david@tethera.net> User-Agent: Notmuch/0.14+211~g71b47e9 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain Cc: David Bremner X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2012 15:40:16 -0000 On Mon, Dec 17 2012, david@tethera.net wrote: > From: David Bremner > > The argument handling in notmuch.c seems due for an overhaul, but > until then use an environment variable to specify a location to write > the talloc leak report to. This is only enabled for the (interesting) > case where some notmuch subcommand is invoked. > --- I'd still suggest to have similar command-line interface option(s) as samba4 use: --leak-report and/or --leak-report-full (search --leak-r in talloc(3) namual page) Tomi > notmuch.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/notmuch.c b/notmuch.c > index 9516dfb..fb49c5a 100644 > --- a/notmuch.c > +++ b/notmuch.c > @@ -322,8 +322,20 @@ main (int argc, char *argv[]) > for (i = 0; i < ARRAY_SIZE (commands); i++) { > command = &commands[i]; > > - if (strcmp (argv[1], command->name) == 0) > - return (command->function) (local, argc - 1, &argv[1]); > + if (strcmp (argv[1], command->name) == 0) { > + int ret; > + char *talloc_report; > + > + ret = (command->function) (local, argc - 1, &argv[1]); > + > + talloc_report=getenv ("NOTMUCH_TALLOC_REPORT"); > + if (talloc_report && strcmp(talloc_report, "") != 0) { > + FILE *report = fopen (talloc_report, "w"); > + talloc_report_full (NULL, report); > + } > + > + return ret; > + } > } > > fprintf (stderr, "Error: Unknown command '%s' (see \"notmuch help\")\n", > -- > 1.7.10.4 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch