Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id CD36A431FBD for ; Tue, 13 May 2014 02:40:24 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PlBbEJSeoQ0s for ; Tue, 13 May 2014 02:40:17 -0700 (PDT) Received: from smtp3.cs.Stanford.EDU (smtp3.cs.Stanford.EDU [171.64.64.27]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 8CEEE431FAF for ; Tue, 13 May 2014 02:40:17 -0700 (PDT) Received: from cs-tor.bu.edu ([204.8.156.142] helo=jane.lan) by smtp3.cs.Stanford.EDU with esmtpsa (UNKNOWN:AES128-GCM-SHA256:128) (Exim 4.80.1) (envelope-from ) id 1Wk9C0-00023j-69; Tue, 13 May 2014 02:40:13 -0700 From: Charles Celerier To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore. In-Reply-To: <877g5rgrqy.fsf@maritornes.cs.unb.ca> References: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu> <87d2fjgtcr.fsf@maritornes.cs.unb.ca> <877g5rgrqy.fsf@maritornes.cs.unb.ca> User-Agent: Notmuch/0.18~rc0+32~gd5092c2 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-apple-darwin13.1.0) Date: Tue, 13 May 2014 05:40:04 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Scan-Signature: 127ff6e1eac6b45a32dc112250ed777d X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 May 2014 09:40:24 -0000 --=-=-= Content-Type: text/plain David Bremner writes: > David Bremner writes: > >> Originally I thought this was uneccesarily intrusive, but on a second >> look I see that there is only one symbol changed that doesn't start with >> _notmuch, so I guess for consistency it's fine. Actually, they all start with _notmuch. The symbol _thread_add_matched_author is not changed. >> I'm thinking about a 0.18.1 point release for build and portability >> fixes; I do think this is a bit too much change for that (especially >> since it doesn't actually fix the symbol hiding test (or more precisely, >> your fix for OS/X breaks the linux test). I agree. > Also, I'd like a less confusing commit message. Do you understand the > situation enough to write one now? In particular it's just a convention > that private symbols should not start with "notmuch", and the actual > hiding happens elsewhere. > > d Yes, I now understand the hiding happens elsewhere. There is a note in devel/STYLE in the "libnotmuch conventions" section that discusses the use of underscores to denote private library functions; I will cite that as the reason for the patch instead. chuck --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBAgAGBQJTceh0AAoJEOjk698fDjuAXHoIAJLE+SmTzjZVFoqeUaKNXml3 UlIq3h+q6lcW6J8ev+ni/qPHkaK+945GSad1BdaILLfgzJJT85/5ZxVo5JRb6Eex XIeqNy/WBGJiqJGr7vkoAoQb0T6aUUEOtV6q9qUBansWVYTUGgaMZQe9SXBWkaf1 SXSWHxhY+MAjd8TmMyzvLKWbXjO53VYrYUQm9X2b1PidHGi9SYAzs2DXe+Yv9gID owg7uZtilUTVEQT7OU79tlU9CjX0AYfJQWC79uznyGzzU3e235ZVPdHBAK8s4Len zBPC6d/mArWsdBt6J0585E2RvJMkIq/wwesTnvggR7V4orZfx7f/c4G3lL1iTSA= =Xm0I -----END PGP SIGNATURE----- --=-=-=--